From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
mingo@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools, script: Add brstackinsn for branch stacks
Date: Thu, 16 Mar 2017 09:25:17 -0300 [thread overview]
Message-ID: <20170316122517.GR12825@kernel.org> (raw)
In-Reply-To: <20170316022218.GE14380@two.firstfloor.org>
Em Wed, Mar 15, 2017 at 07:22:18PM -0700, Andi Kleen escreveu:
> > > + memset(&al, 0, sizeof(al));
> > > + if (end - start > MAXBB - MAXINSN) {
> > > + if (last)
> > > + printf("\tbrstack does not reach to final jump (%" PRIx64 "-%" PRIx64 ")\n",
> > > + start, end);
> > > + else
> > > + printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n",
>
> Thanks. Should be %" PRIu64 " of course.
>
> Arnaldo, can you do the change
Done.
> or should I send a patch?
- Arnaldo
next prev parent reply other threads:[~2017-03-16 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 23:46 [PATCH] perf, tools, script: Add brstackinsn for branch stacks Andi Kleen
2017-03-16 2:16 ` Michael Ellerman
2017-03-16 2:22 ` Andi Kleen
2017-03-16 12:25 ` Arnaldo Carvalho de Melo [this message]
2017-03-16 16:36 ` [tip:perf/core] perf script: Add 'brstackinsn' " tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316122517.GR12825@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.