From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v3 01/16] chardev: add helper function to register char devs with a struct device Date: Fri, 17 Mar 2017 09:24:49 +0900 Message-ID: <20170317002449.GA23896@kroah.com> References: <1488783873-2614-1-git-send-email-logang@deltatee.com> <1488783873-2614-2-git-send-email-logang@deltatee.com> <20170316132222.GA9923@kroah.com> <98d81155-5290-b251-4728-43781d45c23b@deltatee.com> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <98d81155-5290-b251-4728-43781d45c23b-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Logan Gunthorpe Cc: Dan Williams , Alexander Viro , Johannes Thumshirn , Jan Kara , Arnd Bergmann , Sajjan Vikas C , Dmitry Torokhov , Linus Walleij , Alexandre Courbot , Peter Huewe , Marcel Selhorst , Jarkko Sakkinen , Jason Gunthorpe , Olof Johansson , Doug Ledford , Sean Hefty , Hal Rosenstock , Dmitry Vyukov , Haggai Eran , Parav Pandit , Leon Romanovsky , Hartmut Knaack , Lars-Peter Clausen List-Id: linux-gpio@vger.kernel.org On Thu, Mar 16, 2017 at 11:38:40AM -0600, Logan Gunthorpe wrote: > > I don't know why kbuild didn't catch these before, but it looks like we > > really need to include device.h in cdev.h now to fix up these build > > warnings, right? > > > I'll try that out and rebase the char-misc-testing tree in the morning > > to see if that fixes the build problems... > > > Yeah, I think the kbuild robot missed the series because the vger > mailing lists were dropping this series :( > > I also don't know why my kernel config didn't catch this warning but > I reproduced and fixed it with the kbuild's config. I'll send an updated > patch which adds a include device.h line to cdev.h momentarily. Thanks, I've updated my tree with your new patch, let's see what breaks this time :) greg k-h -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3F4698032B for ; Thu, 16 Mar 2017 17:25:33 -0700 (PDT) Date: Fri, 17 Mar 2017 09:24:49 +0900 From: Greg Kroah-Hartman Subject: Re: [PATCH v3 01/16] chardev: add helper function to register char devs with a struct device Message-ID: <20170317002449.GA23896@kroah.com> References: <1488783873-2614-1-git-send-email-logang@deltatee.com> <1488783873-2614-2-git-send-email-logang@deltatee.com> <20170316132222.GA9923@kroah.com> <98d81155-5290-b251-4728-43781d45c23b@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <98d81155-5290-b251-4728-43781d45c23b@deltatee.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: Alessandro Zummo , Jan Kara , linux-iio@vger.kernel.org, linux-pci@vger.kernel.org, Linus Walleij , Jarkko Sakkinen , Alexandre Bounine , Alexandre Belloni , Peter Meerwald-Stadler , linux-scsi@vger.kernel.org, Sean Hefty , Parav Pandit , Peter Huewe , Alexandre Courbot , Lars-Peter Clausen , "James E.J. Bottomley" , rtc-linux@googlegroups.com, Leon Romanovsky , linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, Richard Weinberger , Jason Gunthorpe , Marek Vasut , Doug Ledford , Hans Verkuil , Matt Porter , Hal Rosenstock , linux-media@vger.kernel.org, Boaz Harrosh , Arnd Bergmann , Boris Brezillon , Sajjan Vikas C , linux-input@vger.kernel.org, Marcel Selhorst , Vladimir Zapolskiy , Joe Perches , Cyrille Pitchen , Alexander Viro , Bjorn Helgaas , Mauro Carvalho Chehab , Dmitry Vyukov , linux-fsdevel@vger.kernel.org, Haggai Eran , Lorenzo Stoakes , "Martin K. Petersen" , Artem Bityutskiy , linux-gpio@vger.kernel.org, Dmitry Torokhov , linux-kernel@vger.kernel.org, Stephen Bates , Hartmut Knaack , Olof Johansson , linux-mtd@lists.infradead.org, Andrew Morton , Brian Norris , David Woodhouse List-ID: On Thu, Mar 16, 2017 at 11:38:40AM -0600, Logan Gunthorpe wrote: > > I don't know why kbuild didn't catch these before, but it looks like we > > really need to include device.h in cdev.h now to fix up these build > > warnings, right? > > > I'll try that out and rebase the char-misc-testing tree in the morning > > to see if that fixes the build problems... > > > Yeah, I think the kbuild robot missed the series because the vger > mailing lists were dropping this series :( > > I also don't know why my kernel config didn't catch this warning but > I reproduced and fixed it with the kbuild's config. I'll send an updated > patch which adds a include device.h line to cdev.h momentarily. Thanks, I've updated my tree with your new patch, let's see what breaks this time :) greg k-h _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.linuxfoundation.org ([140.211.169.12]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cofiM-0005qg-FK for linux-mtd@lists.infradead.org; Fri, 17 Mar 2017 00:25:56 +0000 Date: Fri, 17 Mar 2017 09:24:49 +0900 From: Greg Kroah-Hartman To: Logan Gunthorpe Cc: Dan Williams , Alexander Viro , Johannes Thumshirn , Jan Kara , Arnd Bergmann , Sajjan Vikas C , Dmitry Torokhov , Linus Walleij , Alexandre Courbot , Peter Huewe , Marcel Selhorst , Jarkko Sakkinen , Jason Gunthorpe , Olof Johansson , Doug Ledford , Sean Hefty , Hal Rosenstock , Dmitry Vyukov , Haggai Eran , Parav Pandit , Leon Romanovsky , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Hans Verkuil , Mauro Carvalho Chehab , Artem Bityutskiy , Richard Weinberger , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Cyrille Pitchen , Matt Porter , Alexandre Bounine , Andrew Morton , Joe Perches , Lorenzo Stoakes , Vladimir Zapolskiy , Alessandro Zummo , Alexandre Belloni , Boaz Harrosh , "James E.J. Bottomley" , "Martin K. Petersen" , Stephen Bates , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, rtc-linux@googlegroups.com, linux-mtd@lists.infradead.org, linux-media@vger.kernel.org, linux-iio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 01/16] chardev: add helper function to register char devs with a struct device Message-ID: <20170317002449.GA23896@kroah.com> References: <1488783873-2614-1-git-send-email-logang@deltatee.com> <1488783873-2614-2-git-send-email-logang@deltatee.com> <20170316132222.GA9923@kroah.com> <98d81155-5290-b251-4728-43781d45c23b@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98d81155-5290-b251-4728-43781d45c23b@deltatee.com> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Mar 16, 2017 at 11:38:40AM -0600, Logan Gunthorpe wrote: > > I don't know why kbuild didn't catch these before, but it looks like we > > really need to include device.h in cdev.h now to fix up these build > > warnings, right? > > > I'll try that out and rebase the char-misc-testing tree in the morning > > to see if that fixes the build problems... > > > Yeah, I think the kbuild robot missed the series because the vger > mailing lists were dropping this series :( > > I also don't know why my kernel config didn't catch this warning but > I reproduced and fixed it with the kbuild's config. I'll send an updated > patch which adds a include device.h line to cdev.h momentarily. Thanks, I've updated my tree with your new patch, let's see what breaks this time :) greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by gmr-mx.google.com with ESMTPS id 2si1159885pfz.1.2017.03.16.17.25.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Mar 2017 17:25:32 -0700 (PDT) Date: Fri, 17 Mar 2017 09:24:49 +0900 From: Greg Kroah-Hartman To: Logan Gunthorpe Cc: Dan Williams , Alexander Viro , Johannes Thumshirn , Jan Kara , Arnd Bergmann , Sajjan Vikas C , Dmitry Torokhov , Linus Walleij , Alexandre Courbot , Peter Huewe , Marcel Selhorst , Jarkko Sakkinen , Jason Gunthorpe , Olof Johansson , Doug Ledford , Sean Hefty , Hal Rosenstock , Dmitry Vyukov , Haggai Eran , Parav Pandit , Leon Romanovsky , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Hans Verkuil , Mauro Carvalho Chehab , Artem Bityutskiy , Richard Weinberger , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Cyrille Pitchen , Matt Porter , Alexandre Bounine , Andrew Morton , Joe Perches , Lorenzo Stoakes , Vladimir Zapolskiy , Alessandro Zummo , Alexandre Belloni , Boaz Harrosh , "James E.J. Bottomley" , "Martin K. Petersen" , Stephen Bates , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, rtc-linux@googlegroups.com, linux-mtd@lists.infradead.org, linux-media@vger.kernel.org, linux-iio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [rtc-linux] Re: [PATCH v3 01/16] chardev: add helper function to register char devs with a struct device Message-ID: <20170317002449.GA23896@kroah.com> References: <1488783873-2614-1-git-send-email-logang@deltatee.com> <1488783873-2614-2-git-send-email-logang@deltatee.com> <20170316132222.GA9923@kroah.com> <98d81155-5290-b251-4728-43781d45c23b@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <98d81155-5290-b251-4728-43781d45c23b@deltatee.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Thu, Mar 16, 2017 at 11:38:40AM -0600, Logan Gunthorpe wrote: > > I don't know why kbuild didn't catch these before, but it looks like we > > really need to include device.h in cdev.h now to fix up these build > > warnings, right? > > > I'll try that out and rebase the char-misc-testing tree in the morning > > to see if that fixes the build problems... > > > Yeah, I think the kbuild robot missed the series because the vger > mailing lists were dropping this series :( > > I also don't know why my kernel config didn't catch this warning but > I reproduced and fixed it with the kbuild's config. I'll send an updated > patch which adds a include device.h line to cdev.h momentarily. Thanks, I've updated my tree with your new patch, let's see what breaks this time :) greg k-h -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v3 01/16] chardev: add helper function to register char devs with a struct device Date: Fri, 17 Mar 2017 09:24:49 +0900 Message-ID: <20170317002449.GA23896@kroah.com> References: <1488783873-2614-1-git-send-email-logang@deltatee.com> <1488783873-2614-2-git-send-email-logang@deltatee.com> <20170316132222.GA9923@kroah.com> <98d81155-5290-b251-4728-43781d45c23b@deltatee.com> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Dan Williams , Alexander Viro , Johannes Thumshirn , Jan Kara , Arnd Bergmann , Sajjan Vikas C , Dmitry Torokhov , Linus Walleij , Alexandre Courbot , Peter Huewe , Marcel Selhorst , Jarkko Sakkinen , Jason Gunthorpe , Olof Johansson , Doug Ledford , Sean Hefty , Hal Rosenstock , Dmitry Vyukov , Haggai Eran , Parav Pandit , Leon Romanovsky , Hartmut Knaack , Lars-Peter Clausen Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <98d81155-5290-b251-4728-43781d45c23b-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , List-Id: linux-fsdevel.vger.kernel.org On Thu, Mar 16, 2017 at 11:38:40AM -0600, Logan Gunthorpe wrote: > > I don't know why kbuild didn't catch these before, but it looks like we > > really need to include device.h in cdev.h now to fix up these build > > warnings, right? > > > I'll try that out and rebase the char-misc-testing tree in the morning > > to see if that fixes the build problems... > > > Yeah, I think the kbuild robot missed the series because the vger > mailing lists were dropping this series :( > > I also don't know why my kernel config didn't catch this warning but > I reproduced and fixed it with the kbuild's config. I'll send an updated > patch which adds a include device.h line to cdev.h momentarily. Thanks, I've updated my tree with your new patch, let's see what breaks this time :) greg k-h -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.