All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR
Date: Fri, 17 Mar 2017 22:01:05 +0200	[thread overview]
Message-ID: <20170317200105.GV31595@intel.com> (raw)
In-Reply-To: <20170317195430.GT2118@nuc-i3427.alporthouse.com>

On Fri, Mar 17, 2017 at 07:54:30PM +0000, Chris Wilson wrote:
> On Fri, Mar 03, 2017 at 05:19:26PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > The VLV/CHV watermark calculation is really interested in the hardware
> > plane type rather than the plane type (which is more of a software
> > concept). Let's check plane->id rather plane->type.
> > 
> > No functional changes.
> 
> When will they differ? Is this for multipurpose planes, such as a sprite
> that we treat as a cursor for simplicity?

Yeah. Currently they never differ, but just in case someone ever decides
to break that relationship I figured it's better to be clear on which kind
of hardware plane we're dealing with.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-03-17 20:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03 15:19 [PATCH 0/4] drm/i915: Enable atomic for VLV/CHV ville.syrjala
2017-03-03 15:19 ` [PATCH 1/4] drm/i915: Extract intel_wm_plane_visible() ville.syrjala
2017-03-17 19:52   ` Chris Wilson
2017-03-03 15:19 ` [PATCH 2/4] drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR ville.syrjala
2017-03-17 19:54   ` Chris Wilson
2017-03-17 20:01     ` Ville Syrjälä [this message]
2017-03-17 19:56   ` Chris Wilson
2017-03-03 15:19 ` [PATCH 3/4] drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well ville.syrjala
2017-03-17 19:55   ` Chris Wilson
2017-03-03 15:19 ` [PATCH 4/4] drm/i915: Enable atomic on VLV/CHV ville.syrjala
2017-03-06  7:05   ` Maarten Lankhorst
2017-03-03 16:47 ` ✗ Fi.CI.BAT: failure for drm/i915: Enable atomic for VLV/CHV Patchwork
2017-03-03 19:17   ` Ville Syrjälä
2017-03-06 15:48 ` Patchwork
2017-03-15 17:29 ` Patchwork
2017-03-20 19:00 ` Patchwork
2017-03-21 14:31 ` Patchwork
2017-04-04 17:34 ` ✓ Fi.CI.BAT: success " Patchwork
2017-04-05 10:30   ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170317200105.GV31595@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.