Re: [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency

[Denys Dmytriyenko <denys@ti.com>]

On Fri, Mar 17, 2017 at 12:12:24PM -0700, Khem Raj wrote:
> On Fri, Mar 17, 2017 at 12:04 PM, Denys Dmytriyenko <denys@ti.com> wrote:
> > On Fri, Mar 17, 2017 at 11:57:04AM -0700, Khem Raj wrote:
> >> On Fri, Mar 17, 2017 at 10:14 AM, Fathi Boudra <fathi.boudra@linaro.org> wrote:
> >> > On 17 March 2017 at 19:06, Denys Dmytriyenko <denis@denix.org> wrote:
> >> >> On Fri, Mar 17, 2017 at 07:03:55PM +0200, Fathi Boudra wrote:
> >> >>> On 17 March 2017 at 18:59, Denys Dmytriyenko <denis@denix.org> wrote:
> >> >>> > On Fri, Mar 17, 2017 at 04:47:59PM +0000, Khem Raj wrote:
> >> >>> >> On Fri, Mar 17, 2017 at 9:37 AM Fathi Boudra <fathi.boudra@linaro.org>
> >> >>> >> wrote:
> >> >>> >>
> >> >>> >> > libpcap-ng is required to build capabilities tests.
> >> >>> >> >
> >> >>> >> > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> >> >>> >> > ---
> >> >>> >> >  recipes-kernel/kselftests/kselftests_4.9.bb | 4 +---
> >> >>> >> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >> >>> >> >
> >> >>> >> > diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb
> >> >>> >> > b/recipes-kernel/kselftests/kselftests_4.9.bb
> >> >>> >> > index a7b4ba67..dd94a65b 100644
> >> >>> >> > --- a/recipes-kernel/kselftests/kselftests_4.9.bb
> >> >>> >> > +++ b/recipes-kernel/kselftests/kselftests_4.9.bb
> >> >>> >> > @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}"
> >> >>> >> >
> >> >>> >> >  PACKAGE_ARCH = "${MACHINE_ARCH}"
> >> >>> >> >
> >> >>> >> > -DEPENDS = "libcap popt rsync-native"
> >> >>> >> > +DEPENDS = "libcap libcap-ng popt rsync-native"
> >> >>> >>
> >> >>> >>
> >> >>> >> Would ng replace old libcap
> >> >>> >
> >> >>> > Are you asking in general or in this particular case?
> >> >>> >
> >> >>> > kselftests-capabilities does use libcap-ng and includes cap-ng.h header file,
> >> >>> > as I mentioned here:
> >> >>> > https://lists.yoctoproject.org/pipermail/meta-ti/2017-March/009766.html
> >> >>> >
> >> >>> > Fathi's fix is indeed better, even though adding another dependency.
> >> >>>
> >> >>> In this particular case, it doesn't replace libcap.
> >> >>> Upstream managed to use libcap-ng in capabilities test and libpcap in
> >> >>> bpf test...
> >> >>> I'm currently queuing patches for upstream.
> >> >>
> >> >> What the status of the old libcap? Is it being deprecated everywhere?
> >> >
> >> > The traditional libcap is still mainly used. I don't think it's going
> >> > to be deprecated soon, systemd is using it for example.
> >> >
> >>
> >> can both libs live together without stepping on each other ?
> >
> > FWIW, I haven't tested on all platforms yet (still crunching), but the initial
> > results I'm getting here show no build, stage or run-time issues with images
> > that include both kselftests and systemd...
> >
> 
> OK you might want to compare the contents of both packages
> and see if there are any changes that can have effect on behavior subtly.

Looked at all the packaged stuff - cap-ng is very careful to maintain separate 
namespace. There are no conflicts in packaged files - headers, libraries, 
aclocal, pkgconfig, etc. all have cap-ng in the name. Even the new API in the 
header file uses CAPNG_* enums and capng_*() functions:
https://sourcecodebrowser.com/libcap-ng/0.6.5/cap-ng_8h.html

-- 
Denys