From: Bill O'Donnell <billodo@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH (TRIVIAL)] xfs: fix up inode validation failure message
Date: Fri, 17 Mar 2017 15:29:40 -0500 [thread overview]
Message-ID: <20170317202940.GA19030@redhat.com> (raw)
In-Reply-To: <59d16175-1c24-4bc2-5cd9-ac7a062e5ae3@redhat.com>
On Fri, Mar 17, 2017 at 08:47:38AM -0700, Eric Sandeen wrote:
> "xfs_iread: validation failed for inode 96 failed"
>
> One "failed" seems like enough.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
>
> Yo dawg, I heard you like failed so I put failed in your
> failed so you can fail while you fail.
>
> diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
> index d93f9d9..09c3d1a 100644
> --- a/fs/xfs/libxfs/xfs_inode_buf.c
> +++ b/fs/xfs/libxfs/xfs_inode_buf.c
> @@ -508,7 +508,7 @@
>
> /* even unallocated inodes are verified */
> if (!xfs_dinode_verify(mp, ip->i_ino, dip)) {
> - xfs_alert(mp, "%s: validation failed for inode %lld failed",
> + xfs_alert(mp, "%s: validation failed for inode %lld",
> __func__, ip->i_ino);
>
> XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, dip);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-03-17 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 15:47 [PATCH (TRIVIAL)] xfs: fix up inode validation failure message Eric Sandeen
2017-03-17 16:35 ` Alex Elder
2017-03-17 20:29 ` Bill O'Donnell [this message]
2017-03-27 15:21 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317202940.GA19030@redhat.com \
--to=billodo@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.