From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH 16/17] vhost: rename header file
Date: Mon, 20 Mar 2017 13:35:23 +0800
Message-ID: <20170320053523.GJ18844@yliu-dev.sh.intel.com>
References: <1488534682-3494-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1488534682-3494-17-git-send-email-yuanhan.liu@linux.intel.com>
 <ed42456d-288e-204f-b34e-36efd0991c4d@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Harris James R <james.r.harris@intel.com>,
 Liu Changpeng <changpeng.liu@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 0BFD7101B
 for <dev@dpdk.org>; Mon, 20 Mar 2017 06:37:18 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <ed42456d-288e-204f-b34e-36efd0991c4d@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Mar 14, 2017 at 01:59:49PM +0100, Maxime Coquelin wrote:
> 
> 
> On 03/03/2017 10:51 AM, Yuanhan Liu wrote:
> >Rename "rte_virtio_net.h" to "rte_vhost.h", to not let it be virtio
> >net specific.
> >
> >Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >---
> > doc/guides/rel_notes/deprecation.rst   |   9 --
> > drivers/net/vhost/rte_eth_vhost.c      |   2 +-
> > drivers/net/vhost/rte_eth_vhost.h      |   2 +-
> > examples/tep_termination/main.c        |   2 +-
> > examples/tep_termination/vxlan_setup.c |   2 +-
> > examples/vhost/main.c                  |   2 +-
> > lib/librte_vhost/Makefile              |   2 +-
> > lib/librte_vhost/rte_vhost.h           | 259 +++++++++++++++++++++++++++++++++
> > lib/librte_vhost/rte_virtio_net.h      | 259 ---------------------------------
> Did you perform the rename using git mv?

Yes, and I forgot to add '-M' option while run "git format-patch".

	--yliu
> 
> > lib/librte_vhost/vhost.c               |   2 +-
> > lib/librte_vhost/vhost.h               |   2 +-
> > lib/librte_vhost/vhost_user.h          |   2 +-
> > lib/librte_vhost/virtio_net.c          |   2 +-
> > 13 files changed, 269 insertions(+), 278 deletions(-)
> > create mode 100644 lib/librte_vhost/rte_vhost.h
> > delete mode 100644 lib/librte_vhost/rte_virtio_net.h
> 
> Other than that, the change looks good to me:
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Thanks,
> Maxime