From: Stephen Hemminger <stephen@networkplumber.org>
To: Felix Manlunas <felix.manlunas@cavium.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
raghu.vatsavayi@cavium.com, derek.chickles@cavium.com,
satananda.burla@cavium.com, ricardo.farrington@cavium.com
Subject: Re: [PATCH net-next] liquidio: use meaningful names for IRQs
Date: Mon, 20 Mar 2017 08:15:30 -0700 [thread overview]
Message-ID: <20170320081530.0f4cdbee@xeon-e3> (raw)
In-Reply-To: <20170313195804.GA1796@felix2.cavium.com>
On Mon, 13 Mar 2017 12:58:04 -0700
Felix Manlunas <felix.manlunas@cavium.com> wrote:
> From: Rick Farrington <ricardo.farrington@cavium.com>
>
> All IRQs owned by the PF and VF drivers share the same nondescript name
> "octeon"; this makes it difficult to setup interrupt affinity.
>
> Change the IRQ names to reflect their specific purpose:
>
> LiquidIO<id>-<func>-<type>-<queue pair num>
>
> Examples:
> LiquidIO0-pf0-rxtx-3
> LiquidIO1-vf1-rxtx-0
> LiquidIO0-pf0-aux
>
> We cannot use netdev->name for naming the IRQs because:
>
> 1. Early during init, the PF and VF drivers require interrupts to
> send/receive control data from the NIC firmware; so the PF and VF
> must request IRQs long before the netdev struct is registered.
>
> 2. The IRQ name can only be specified at the time it is requested.
> It cannot be changed after that.
>
> Signed-off-by: Rick Farrington <ricardo.farrington@cavium.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com>
> Signed-off-by: Satanand Burla <satananda.burla@cavium.com>
Irqbalance used to parse the interrupt names and expect the network device name.
next prev parent reply other threads:[~2017-03-20 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 19:58 [PATCH net-next] liquidio: use meaningful names for IRQs Felix Manlunas
2017-03-17 3:20 ` David Miller
2017-03-20 8:26 ` Mintz, Yuval
2017-03-20 15:15 ` Stephen Hemminger [this message]
2017-04-03 9:55 ` Sunil Kovvuri
2017-04-03 15:03 ` Ricardo Farrington
2017-04-03 17:42 ` Sunil Kovvuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320081530.0f4cdbee@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=derek.chickles@cavium.com \
--cc=felix.manlunas@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@cavium.com \
--cc=ricardo.farrington@cavium.com \
--cc=satananda.burla@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.