From: Thierry Reding <thierry.reding@gmail.com>
To: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>, Imre Kaloz <kaloz@openwrt.org>,
Alexandre Courbot <gnurou@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"David S. Miller" <davem@davemloft.net>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Guenter Roeck <linux@roeck-us.net>,
"open list:PWM SUBSYSTEM" <linux-pwm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support
Date: Mon, 20 Mar 2017 14:51:31 +0100 [thread overview]
Message-ID: <20170320135131.GP22463@ulmo.ba.sec> (raw)
In-Reply-To: <20170317101747.67a09ccd@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
On Fri, Mar 17, 2017 at 10:17:47AM +0100, Ralph Sennhauser wrote:
> On Thu, 16 Mar 2017 17:03:05 +0100
> Linus Walleij <linus.walleij@linaro.org> wrote:
[...]
> > > +static void mvebu_pwm_suspend(struct mvebu_gpio_chip *mvchip)
> > > +static void mvebu_pwm_resume(struct mvebu_gpio_chip *mvchip)
> >
> > I think both of these need to be tagged __maybe_unused to not give
> > noise in randconfig builds.
>
> I haven't seen any warnings with CONFIG_PWM disabled. Which
> configuration you expect to trigger a warning? mvebu_pwm_probe should
> be the same, right?
It's got nothing to do with CONFIG_PWM and as far as I can tell your
usage of IS_ENABLED() is fine here. However, if you try building the
driver with a !PM configuration, both *_suspend() and *_resume() end
up being unused and giving you a warning.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-03-20 13:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 6:42 [PATCH 0/4] gpio: mvebu: Add PWM fan support Ralph Sennhauser
2017-03-16 6:42 ` Ralph Sennhauser
[not found] ` <20170316064218.9169-1-ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-16 6:42 ` [PATCH 1/4] gpio: mvebu: Add limited PWM support Ralph Sennhauser
2017-03-16 6:42 ` Ralph Sennhauser
[not found] ` <20170316064218.9169-2-ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-16 16:03 ` Linus Walleij
2017-03-16 16:03 ` Linus Walleij
2017-03-17 9:17 ` Ralph Sennhauser
2017-03-20 13:51 ` Thierry Reding [this message]
2017-03-21 6:31 ` Ralph Sennhauser
2017-03-23 10:11 ` Linus Walleij
2017-03-23 10:35 ` Ralph Sennhauser
2017-03-18 15:37 ` Andrew Lunn
2017-03-20 13:49 ` Thierry Reding
2017-03-20 13:44 ` Thierry Reding
2017-03-20 13:42 ` Thierry Reding
2017-03-21 6:36 ` Ralph Sennhauser
2017-03-21 14:50 ` Andrew Lunn
2017-03-16 6:42 ` [PATCH 2/4] mvebu: xp: Add pwm properties to .dtsi files Ralph Sennhauser
2017-03-16 6:42 ` Ralph Sennhauser
2017-03-16 6:42 ` Ralph Sennhauser
2017-03-16 6:42 ` [PATCH 3/4] ARM: mvebu: Enable SENSORS_PWM_FAN in defconfig Ralph Sennhauser
2017-03-16 6:42 ` Ralph Sennhauser
2017-03-16 6:42 ` Ralph Sennhauser
2017-03-16 6:42 ` [PATCH 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Ralph Sennhauser
2017-03-16 6:42 ` Ralph Sennhauser
2017-03-16 6:42 ` Ralph Sennhauser
2017-03-16 15:45 ` [PATCH 0/4] gpio: mvebu: Add PWM fan support Linus Walleij
2017-03-18 15:39 ` Andrew Lunn
2017-03-18 15:50 ` Ralph Sennhauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320135131.GP22463@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kaloz@openwrt.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=ralph.sennhauser@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.