From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: tegra-bpmp: Enable Tegra BPMP I2C adapter
Date: Mon, 20 Mar 2017 15:05:03 +0100 [thread overview]
Message-ID: <20170320140503.GA28203@ulmo.ba.sec> (raw)
In-Reply-To: <1489580410-9541-1-git-send-email-jonathanh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]
On Wed, Mar 15, 2017 at 12:20:10PM +0000, Jon Hunter wrote:
> Enable the Tegra BPMP I2C adapter by default if the Tegra BPMP itself
> is enabled. This adapter is used as the I2C interface for the PMIC on
> the Tegra186 Jetson-TX2 platform.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/i2c/busses/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 8adc0f1d7ad0..9e024ae8a067 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -933,6 +933,7 @@ config I2C_TEGRA
> config I2C_TEGRA_BPMP
> tristate "NVIDIA Tegra BPMP I2C controller"
> depends on TEGRA_BPMP
> + default y if TEGRA_BPMP
I think "if TEGRA_BPMP" in the line above implies "depends on
TEGRA_BPMP", so it's redundant. "default y" should be equivalent. That
said, I'm not sure if we really want to always enable this. There could
be boards with a BPMP that don't use the I2C controller.
But that's fairly unlikely, so with the redundant dependency on
TEGRA_BPMP fixed, this is:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-03-20 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 12:20 [PATCH] i2c: tegra-bpmp: Enable Tegra BPMP I2C adapter Jon Hunter
2017-03-15 12:20 ` Jon Hunter
2017-03-20 14:05 ` Thierry Reding [this message]
2017-03-24 9:30 ` Jon Hunter
2017-03-24 9:30 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320140503.GA28203@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.