From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: Potential BUG in drm/i915/execlists: Reset RING registers upon resume Date: Mon, 20 Mar 2017 16:13:58 +0100 Message-ID: <20170320151358.GB14800@kroah.com> References: <1489443835.5568.7.camel@mailbox.org> <87fui8at69.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 861D96E5CB for ; Mon, 20 Mar 2017 15:14:12 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87fui8at69.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Damian Dominik Martinez Dreyer , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Eric Blau List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMjAsIDIwMTcgYXQgMDU6MDE6MzRQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVHVlLCAxNCBNYXIgMjAxNywgRXJpYyBCbGF1IDxlYmxhdUBlYmxhdS5jb20+IHdy b3RlOgo+ID4gVGhhdCdzIGZ1bm55LiBJIGhhdmUgYSBNYWNCb29rIFBybyAxMiwxIGZyb20gbGF0 ZSAyMDE1LiBIaWJlcm5hdGUKPiA+IGZhaWxlZCBmb3IgbWUgaW4gNC45LjYgdGhyb3VnaCA0Ljku OCAocG9zc2libHkgZWFybGllciBhcyB3ZWxsLCBJIGRvCj4gPiBubyByZWNhbGwpIHdpdGhvdXQg dGhlIHBhdGNoLiBUaGUgcGF0Y2ggeW91IHJlZmVyZW5jZSBmaXhlZCBteSBwcm9ibGVtCj4gPiBh bmQgYXBwYXJlbnRseSBtYW55IG90aGVycyBiYXNlZCBvbiB0aGUgYnVnIHJlcG9ydHM6Cj4gPgo+ ID4gaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY1MjYKPiA+ Cj4gPiBJIGFwcGxpZWQgdGhlIHBhdGNoIG15c2VsZiBpbiA0LjkuNiB0aHJvdWdoIDQuOS44IGFu ZCBoaWJlcm5hdGUgd29ya3MKPiA+IGZvciBtZS4gSSBoYXZlIHJ1biB2YW5pbGxhIDQuOS45IGFu ZCA0LjEwLjEgYW5kIGluIGJvdGggaGliZXJuYXRlCj4gPiB3b3Jrcy4KPiAKPiBTbyBJJ20gcXVp dGUgc3VycHJpc2VkCj4gCj4gY29tbWl0IGYyYTA0MDlhMDg1MDJkNjRmYmUzOTkwMzU0ZGZmNTkw MmIwOGQyZmIKPiBBdXRob3I6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVr Pgo+IERhdGU6ICAgV2VkIFNlcCAyMSAxNDo1MTowOCAyMDE2ICswMTAwCj4gCj4gICAgIGRybS9p OTE1L2V4ZWNsaXN0czogUmVzZXQgUklORyByZWdpc3RlcnMgdXBvbiByZXN1bWUKPiAgICAgCj4g ICAgIGNvbW1pdCBiYWZiMmY3ZDQ3NTViZjE1NzFiZDVlOWEwM2I5N2YzZmM0ZmU2OWFlIHVwc3Ry ZWFtLgo+IAo+IGVuZGVkIHVwIGluIHY0LjkuOSBjb25zaWRlcmluZyB0aGF0IHRoZSB1cHN0cmVh bSBjb21taXQgaXMgbm90IGFubm90YXRlZAo+IGZvciBzdGFibGUsIGl0IGhhcyBubyBGaXhlczog dGFncywgYW5kIEkgY2FuJ3QgZmluZCBhbnkgYmFja3BvcnQKPiByZXF1ZXN0cyBvciBldmVuIG5v dGlmaWNhdGlvbnMgZm9yIGl0IGluIG15IG1haWxzLiAoQWRtaXR0ZWRseSBJJ20gbm90Cj4gc3Vi c2NyaWJlZCBvbiBzdGFibGVALCBidXQgSSdkIGV4cGVjdCBvdXIgbGlzdHMsIG1haW50YWluZXJz IG9yCj4gZGV2ZWxvcGVycyBiZSBDYydkLikKCkVyaWMgc2VudCB0aGlzIHRvIHRoZSBzdGFibGUg bGlzdCBhIGZldyB0aW1lcywgbXkgbWlzdGFrZSBmb3Igbm90IHNlZWluZwpoZSBoYWRuJ3QgYWxz byBjYzplZCB0aGUgZGV2ZWxvcGVyIGxpc3QuCgpXYW50IG1lIHRvIHJldmVydCBpdD8KCnRoYW5r cywKCmdyZWcgay1oCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:41934 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751972AbdCTPWV (ORCPT ); Mon, 20 Mar 2017 11:22:21 -0400 Date: Mon, 20 Mar 2017 16:13:58 +0100 From: Greg Kroah-Hartman To: Jani Nikula Cc: Eric Blau , Damian Dominik Martinez Dreyer , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Chris Wilson Subject: Re: [Intel-gfx] Potential BUG in drm/i915/execlists: Reset RING registers upon resume Message-ID: <20170320151358.GB14800@kroah.com> References: <1489443835.5568.7.camel@mailbox.org> <87fui8at69.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87fui8at69.fsf@intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Mar 20, 2017 at 05:01:34PM +0200, Jani Nikula wrote: > On Tue, 14 Mar 2017, Eric Blau wrote: > > That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate > > failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do > > no recall) without the patch. The patch you reference fixed my problem > > and apparently many others based on the bug reports: > > > > https://bugs.freedesktop.org/show_bug.cgi?id=96526 > > > > I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works > > for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate > > works. > > So I'm quite surprised > > commit f2a0409a08502d64fbe3990354dff5902b08d2fb > Author: Chris Wilson > Date: Wed Sep 21 14:51:08 2016 +0100 > > drm/i915/execlists: Reset RING registers upon resume > > commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream. > > ended up in v4.9.9 considering that the upstream commit is not annotated > for stable, it has no Fixes: tags, and I can't find any backport > requests or even notifications for it in my mails. (Admittedly I'm not > subscribed on stable@, but I'd expect our lists, maintainers or > developers be Cc'd.) Eric sent this to the stable list a few times, my mistake for not seeing he hadn't also cc:ed the developer list. Want me to revert it? thanks, greg k-h