From: Christoph Hellwig <hch@infradead.org>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>,
mtk.manpages@gmail.com, Christoph Hellwig <hch@infradead.org>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Linux API <linux-api@vger.kernel.org>,
linux-xfs@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] statx: reject unknown flags when using NULL path
Date: Mon, 20 Mar 2017 10:44:22 -0700 [thread overview]
Message-ID: <20170320174422.GA9304@infradead.org> (raw)
In-Reply-To: <20170320171142.GA26906@gmail.com>
On Mon, Mar 20, 2017 at 10:11:42AM -0700, Eric Biggers wrote:
> On Fri, Mar 10, 2017 at 10:58:23PM -0800, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > The statx() system call currently accepts unknown flags when called with
> > a NULL path to operate on a file descriptor. Left unchanged, this could
> > make it hard to introduce new query flags in the future, since
> > applications may not be able to tell whether a given flag is supported.
> >
> > Fix this by failing the system call with EINVAL if any flags other than
> > KSTAT_QUERY_FLAGS are specified in combination with a NULL path.
> >
>
> Does anyone have comments on this patch?
Looks good to me.
> I really think we need to get this in before v4.11 is released, since it deals
> with the API.
Yes. And we really need test for all of this. Or just revert the
patches. Shipping with untested syscalls is just a desaster.
next prev parent reply other threads:[~2017-03-20 17:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 6:58 [PATCH] statx: reject unknown flags when using NULL path Eric Biggers
2017-03-11 6:58 ` Eric Biggers
2017-03-20 17:11 ` Eric Biggers
2017-03-20 17:44 ` Christoph Hellwig [this message]
2017-03-31 15:39 ` Christoph Hellwig
2017-03-31 15:43 ` Al Viro
[not found] ` <20170331154315.GB29622-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2017-03-31 15:51 ` David Howells
2017-03-31 15:51 ` David Howells
[not found] ` <21301.1490975484-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-03-31 16:02 ` Christoph Hellwig
2017-03-31 16:02 ` Christoph Hellwig
[not found] ` <20170331160224.GA27791-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-03-31 16:58 ` David Howells
2017-03-31 16:58 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320174422.GA9304@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=dhowells@redhat.com \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.