From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 20 Mar 2017 15:29:26 -0700 From: Brian Norris To: Shawn Lin Cc: Bjorn Helgaas , linux-kernel@vger.kernel.org, Jeffy Chen , Wenrui Li , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 3/5] PCI: rockchip: add remove() support Message-ID: <20170320222925.GA78325@google.com> References: <20170310024617.67303-1-briannorris@chromium.org> <20170310024617.67303-3-briannorris@chromium.org> <5cec190e-4eee-fc55-7039-2336ba5253f3@rock-chips.com> <20170310194011.GA16352@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: On Mon, Mar 13, 2017 at 10:26:12AM +0800, Shawn Lin wrote: > I just thought we should fix the domain number here by adding > "linux,pci-domain = <0>" for rk3399.dtsi, which seems more wise > to me now. Does it make sense to you? I think that's fine (as noted in response to your patch). That doesn't really prevent this from being a core PCI domain bug though... BTW, I've been using this patch set to do some repeated remove/probe testing, and aside from the domain renumbering question and a small memory leak noticed by kmemleak (an existing bug; sending a patch shortly), this has been working well for me. Brian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH v2 3/5] PCI: rockchip: add remove() support Date: Mon, 20 Mar 2017 15:29:26 -0700 Message-ID: <20170320222925.GA78325@google.com> References: <20170310024617.67303-1-briannorris@chromium.org> <20170310024617.67303-3-briannorris@chromium.org> <5cec190e-4eee-fc55-7039-2336ba5253f3@rock-chips.com> <20170310194011.GA16352@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Shawn Lin Cc: Jeffy Chen , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wenrui Li , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Bjorn Helgaas List-Id: linux-rockchip.vger.kernel.org On Mon, Mar 13, 2017 at 10:26:12AM +0800, Shawn Lin wrote: > I just thought we should fix the domain number here by adding > "linux,pci-domain = <0>" for rk3399.dtsi, which seems more wise > to me now. Does it make sense to you? I think that's fine (as noted in response to your patch). That doesn't really prevent this from being a core PCI domain bug though... BTW, I've been using this patch set to do some repeated remove/probe testing, and aside from the domain renumbering question and a small memory leak noticed by kmemleak (an existing bug; sending a patch shortly), this has been working well for me. Brian