All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Michael J. Ruhl"
	<michael.j.ruhl-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: [PATCH v2 15/20] IB/hfi1: Ensure VL index is within bounds
Date: Mon, 20 Mar 2017 17:26:07 -0700	[thread overview]
Message-ID: <20170321002606.28538.30066.stgit@scvm10.sc.intel.com> (raw)
In-Reply-To: <20170321001900.28538.38175.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>

From: Michael J. Ruhl <michael.j.ruhl-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Improve the safety of the code and ensure the array cannot be indexed
out of bounds when picking the CPU for a given SDMA engine.

Reviewed-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 drivers/infiniband/hw/hfi1/sdma.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/hw/hfi1/sdma.c b/drivers/infiniband/hw/hfi1/sdma.c
index 9bee28d..1f7bf30 100644
--- a/drivers/infiniband/hw/hfi1/sdma.c
+++ b/drivers/infiniband/hw/hfi1/sdma.c
@@ -962,6 +962,11 @@ ssize_t sdma_set_cpu_to_sde_map(struct sdma_engine *sde, const char *buf,
 			continue;
 		}
 
+		if (vl >= ARRAY_SIZE(rht_node->map)) {
+			ret = -EINVAL;
+			goto out;
+		}
+
 		rht_node = rhashtable_lookup_fast(dd->sdma_rht, &cpu,
 						  sdma_rht_params);
 		if (!rht_node) {

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-03-21  0:26 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21  0:24 [PATCH v2 00/20] IB/hfi1, qib, rdmavt: Another round of patches for 4.11 Dennis Dalessandro
2017-03-21  0:24 ` Dennis Dalessandro
     [not found] ` <20170321001900.28538.38175.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-03-21  0:24   ` [PATCH v2 01/20] IB/hfi1: Force logical link down Dennis Dalessandro
2017-03-21  0:24   ` [PATCH v2 02/20] IB/hfi1: Race hazard avoidance in user SDMA driver Dennis Dalessandro
2017-03-21  0:24   ` [PATCH v2 03/20] IB/hfi1: Cache registers during state change Dennis Dalessandro
2017-03-21  0:24   ` [PATCH v2 04/20] IB/hfi1: NULL pointer dereference when freeing rhashtable Dennis Dalessandro
2017-03-21  0:25   ` [PATCH v2 05/20] IB/rdmavt, IB/hfi1, IB/qib: Make wc opcode translation driver dependent Dennis Dalessandro
2017-03-21  0:25   ` [PATCH v2 06/20] IB/rdmavt: Add additional fields to post send trace Dennis Dalessandro
2017-03-21  0:25   ` [PATCH v2 07/20] IB/rdmavt: Add tracing for cq entry and poll Dennis Dalessandro
2017-03-21  0:25   ` [PATCH v2 08/20] IB/rdmavt: Add swqe completion trace Dennis Dalessandro
2017-03-21  0:25   ` [PATCH v2 09/20] IB/hfi1: Check device id early during init Dennis Dalessandro
2017-03-21  0:25   ` [PATCH v2 10/20] IB/hfi1: Protect the global dev_cntr_names and port_cntr_names Dennis Dalessandro
2017-03-21  0:25   ` [PATCH v2 11/20] IB/hfi1: Check for QSFP presence before attempting reads Dennis Dalessandro
2017-03-21  0:25   ` [PATCH v2 12/20] IB/hfi1: Add a patch value to the firmware version string Dennis Dalessandro
2017-03-21  0:25   ` [PATCH v2 13/20] IB/rdmavt, IB/hfi1: Fix timer migration regressions Dennis Dalessandro
2017-03-21  0:26   ` [PATCH v2 14/20] IB/rdmavt: Avoid reseting wqe send_flags in unreserve Dennis Dalessandro
2017-03-21  0:26   ` Dennis Dalessandro [this message]
2017-03-21  0:26   ` [PATCH v2 16/20] IB/hfi1: Add receive fault injection feature Dennis Dalessandro
2017-03-21  0:26   ` [PATCH v2 17/20] IB/hfi1: Add transmit " Dennis Dalessandro
     [not found]     ` <20170321002619.28538.31428.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-04-05 18:34       ` Doug Ledford
     [not found]         ` <1491417255.2923.5.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-04-05 18:49           ` Dennis Dalessandro
2017-03-21  0:26   ` [PATCH v2 18/20] IB/hfi1: Eliminate synchronize_rcu() in mr delete Dennis Dalessandro
2017-03-21  0:26   ` [PATCH v2 19/20] IB/rdmavt, IB/qib, IB/hfi1: Make percpu refcount optional for user MRs Dennis Dalessandro
     [not found]     ` <20170321002631.28538.2121.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-04-05 18:38       ` Doug Ledford
     [not found]         ` <1491417489.2923.6.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-04-05 19:46           ` Dennis Dalessandro
     [not found]             ` <f008c532-340e-01f2-80e6-4bea74175e3e-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-05 19:51               ` Leon Romanovsky
     [not found]                 ` <CALq1K=JsjSCiSBeZVe4kHQmjw7tznL36JcsamZTVGZ5RhBvZPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-05 20:09                   ` Marciniszyn, Mike
     [not found]                     ` <32E1700B9017364D9B60AED9960492BC342EA858-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-04-06  7:49                       ` Leon Romanovsky
     [not found]                         ` <20170406074955.GG2269-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-04-06 11:45                           ` Dennis Dalessandro
     [not found]                             ` <8cdf2fbb-f2a9-0b4b-b144-397ee73d1569-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-06 12:37                               ` Leon Romanovsky
     [not found]                                 ` <20170406123726.GH2269-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-04-06 13:00                                   ` Dennis Dalessandro
     [not found]                                     ` <f1703866-9c5c-a30a-0d95-9f6a33cc4f75-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-06 13:33                                       ` Leon Romanovsky
2017-04-06 14:47                               ` Marciniszyn, Mike
     [not found]                                 ` <32E1700B9017364D9B60AED9960492BC342EABD0-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-04-06 17:13                                   ` Jason Gunthorpe
     [not found]                                     ` <20170406171354.GA19854-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-06 17:16                                       ` Marciniszyn, Mike
     [not found]                                         ` <32E1700B9017364D9B60AED9960492BC342EADEE-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-04-06 17:44                                           ` Jason Gunthorpe
     [not found]                                             ` <20170406174438.GA20020-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-07 21:12                                               ` Marciniszyn, Mike
     [not found]                                                 ` <32E1700B9017364D9B60AED9960492BC342EBA18-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-04-07 22:06                                                   ` Jason Gunthorpe
     [not found]                                                     ` <20170407220618.GA29138-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-09  6:26                                                       ` Leon Romanovsky
2017-04-05 19:47           ` Leon Romanovsky
2017-03-21  0:26 ` [PATCH v2 20/20] IB/core: If the MGID/MLID pair is not on the list return an error Dennis Dalessandro
2017-04-05 18:50 ` [PATCH v2 00/20] IB/hfi1, qib, rdmavt: Another round of patches for 4.11 Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170321002606.28538.30066.stgit@scvm10.sc.intel.com \
    --to=dennis.dalessandro-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=michael.j.ruhl-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.