From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH] tpm/tpm_crb: fix unused warnings on suspend/resume functions Date: Tue, 21 Mar 2017 10:03:53 +0200 Message-ID: <20170321080353.oh2apppp37nchuw7@intel.com> References: <20170317015133.2269-1-jeremy.lefaure@lse.epita.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170317015133.2269-1-jeremy.lefaure-tU7rkvAWjlwhT4uAktR2oQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: =?iso-8859-1?B?Suly6W15?= Lefaure Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net T24gVGh1LCBNYXIgMTYsIDIwMTcgYXQgMDk6NTE6MzNQTSAtMDQwMCwgSsOpcsOpbXkgTGVmYXVy ZSB3cm90ZToKPiBXaGVuIFBNX1NMRUVQIGlzIGRpc2FibGVkIGNyYl9wbV9zdXNwZW5kIGFuZCBj cmJfcG1fcmVzdW1lIGFyZSBub3QgdXNlZCBieQo+IFNFVF9TWVNURU1fU0xFRVBfUE1fT1BTIGV2 ZW4gaWYgUE0gaXMgZW5hYmxlZDoKPiAKPiBkcnZlcnMvY2hhci90cG0vdHBtX2NyYi5jOjU0MDox Mjogd2FybmluZzog4oCYY3JiX3BtX3N1c3BlbmTigJkgZGVmaW5lZCBidXQgbm90Cj4gdXNlZCBb LVd1bnVzZWQtZnVuY3Rpb25dCj4gIHN0YXRpYyBpbnQgY3JiX3BtX3N1c3BlbmQoc3RydWN0IGRl dmljZSAqZGV2KQo+ICAgICAgICAgICAgIF4KPiBkcml2ZXJzL2NoYXIvdHBtL3RwbV9jcmIuYzo1 NTE6MTI6IHdhcm5pbmc6IOKAmGNyYl9wbV9yZXN1bWXigJkgZGVmaW5lZCBidXQgbm90Cj4gdXNl ZCBbLVd1bnVzZWQtZnVuY3Rpb25dCj4gIHN0YXRpYyBpbnQgY3JiX3BtX3Jlc3VtZShzdHJ1Y3Qg ZGV2aWNlICpkZXYpCj4gICAgICAgICAgICAgXgo+IAo+IFRoZSBwcmVwcm9jZXNzb3IgY29uZGl0 aW9uIHNob3VsZCBiZSBvbiBDT05GSUdfUE1fU0xFRVAsIG5vdCBvbiBDT05GSUdfUE0uCj4gSG93 ZXZlciwgdGhpcyBwYXRjaCBmaXhlcyB0aGlzIHdhcm5pbmcgYnkgdXNpbmcgX19tYXliZV91bnVz ZWQgb24gZnVuY3Rpb24KPiB0aGF0IGFyZSBpbiB0aGUgcHJlcHJvY2Vzc29yIGNvbmRpdGlvbi4K PiAKPiBTaWduZWQtb2ZmLWJ5OiBKw6lyw6lteSBMZWZhdXJlIDxqZXJlbXkubGVmYXVyZUBsc2Uu ZXBpdGEuZnI+CgpUaGFua3MuIFBsZWFzZSBpbmNsdWRlIGFsc28gbGludXgta2VybmVsQHZnZXIu a2VybmVsLm9yZyBpbiB0aGUgZnV0dXJlLgoKUmV2aWV3ZWQtYnk6IEphcmtrbyBTYXNra2luZW4g PGphcmtrby5zYWtraW5lbkBsaW51eC5pbnRlbC5jb20+CgovSmFya2tvCgo+IC0tLQo+ICBkcml2 ZXJzL2NoYXIvdHBtL3RwbV9jcmIuYyB8IDExICsrKystLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCA0IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvY2hhci90cG0vdHBtX2NyYi5jIGIvZHJpdmVycy9jaGFyL3RwbS90cG1fY3JiLmMKPiBpbmRl eCAzMjQ1NjE4NDVkYzIuLjA0NGFmYjczZmRlYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2NoYXIv dHBtL3RwbV9jcmIuYwo+ICsrKyBiL2RyaXZlcnMvY2hhci90cG0vdHBtX2NyYi5jCj4gQEAgLTUy MCw4ICs1MjAsNyBAQCBzdGF0aWMgaW50IGNyYl9hY3BpX3JlbW92ZShzdHJ1Y3QgYWNwaV9kZXZp Y2UgKmRldmljZSkKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IC0jaWZkZWYgQ09ORklHX1BNCj4g LXN0YXRpYyBpbnQgY3JiX3BtX3J1bnRpbWVfc3VzcGVuZChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4g K3N0YXRpYyBpbnQgX19tYXliZV91bnVzZWQgY3JiX3BtX3J1bnRpbWVfc3VzcGVuZChzdHJ1Y3Qg ZGV2aWNlICpkZXYpCj4gIHsKPiAgCXN0cnVjdCB0cG1fY2hpcCAqY2hpcCA9IGRldl9nZXRfZHJ2 ZGF0YShkZXYpOwo+ICAJc3RydWN0IGNyYl9wcml2ICpwcml2ID0gZGV2X2dldF9kcnZkYXRhKCZj aGlwLT5kZXYpOwo+IEBAIC01MjksNyArNTI4LDcgQEAgc3RhdGljIGludCBjcmJfcG1fcnVudGlt ZV9zdXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRldikKPiAgCXJldHVybiBjcmJfZ29faWRsZShkZXYs IHByaXYpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IGNyYl9wbV9ydW50aW1lX3Jlc3VtZShzdHJ1 Y3QgZGV2aWNlICpkZXYpCj4gK3N0YXRpYyBpbnQgX19tYXliZV91bnVzZWQgY3JiX3BtX3J1bnRp bWVfcmVzdW1lKHN0cnVjdCBkZXZpY2UgKmRldikKPiAgewo+ICAJc3RydWN0IHRwbV9jaGlwICpj aGlwID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gIAlzdHJ1Y3QgY3JiX3ByaXYgKnByaXYgPSBk ZXZfZ2V0X2RydmRhdGEoJmNoaXAtPmRldik7Cj4gQEAgLTUzNyw3ICs1MzYsNyBAQCBzdGF0aWMg aW50IGNyYl9wbV9ydW50aW1lX3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIAlyZXR1cm4g Y3JiX2NtZF9yZWFkeShkZXYsIHByaXYpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IGNyYl9wbV9z dXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRldikKPiArc3RhdGljIGludCBfX21heWJlX3VudXNlZCBj cmJfcG1fc3VzcGVuZChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIHsKPiAgCWludCByZXQ7Cj4gIAo+ IEBAIC01NDgsNyArNTQ3LDcgQEAgc3RhdGljIGludCBjcmJfcG1fc3VzcGVuZChzdHJ1Y3QgZGV2 aWNlICpkZXYpCj4gIAlyZXR1cm4gY3JiX3BtX3J1bnRpbWVfc3VzcGVuZChkZXYpOwo+ICB9Cj4g IAo+IC1zdGF0aWMgaW50IGNyYl9wbV9yZXN1bWUoc3RydWN0IGRldmljZSAqZGV2KQo+ICtzdGF0 aWMgaW50IF9fbWF5YmVfdW51c2VkIGNyYl9wbV9yZXN1bWUoc3RydWN0IGRldmljZSAqZGV2KQo+ ICB7Cj4gIAlpbnQgcmV0Owo+ICAKPiBAQCAtNTU5LDggKzU1OCw2IEBAIHN0YXRpYyBpbnQgY3Ji X3BtX3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIAlyZXR1cm4gdHBtX3BtX3Jlc3VtZShk ZXYpOwo+ICB9Cj4gIAo+IC0jZW5kaWYgLyogQ09ORklHX1BNICovCj4gLQo+ICBzdGF0aWMgY29u c3Qgc3RydWN0IGRldl9wbV9vcHMgY3JiX3BtID0gewo+ICAJU0VUX1NZU1RFTV9TTEVFUF9QTV9P UFMoY3JiX3BtX3N1c3BlbmQsIGNyYl9wbV9yZXN1bWUpCj4gIAlTRVRfUlVOVElNRV9QTV9PUFMo Y3JiX3BtX3J1bnRpbWVfc3VzcGVuZCwgY3JiX3BtX3J1bnRpbWVfcmVzdW1lLCBOVUxMKQo+IC0t IAo+IDIuMTIuMAo+IAoKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkNoZWNrIG91dCB0aGUgdmlicmFu dCB0ZWNoIGNvbW11bml0eSBvbiBvbmUgb2YgdGhlIHdvcmxkJ3MgbW9zdAplbmdhZ2luZyB0ZWNo IHNpdGVzLCBTbGFzaGRvdC5vcmchIGh0dHA6Ly9zZG0ubGluay9zbGFzaGRvdApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwp0cG1kZC1kZXZlbCBtYWlsaW5n IGxpc3QKdHBtZGQtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291 cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL3RwbWRkLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756864AbdCUIEN (ORCPT ); Tue, 21 Mar 2017 04:04:13 -0400 Received: from mga01.intel.com ([192.55.52.88]:55955 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755141AbdCUIEJ (ORCPT ); Tue, 21 Mar 2017 04:04:09 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,198,1486454400"; d="scan'208";a="946522958" Date: Tue, 21 Mar 2017 10:03:53 +0200 From: Jarkko Sakkinen To: =?iso-8859-1?B?Suly6W15?= Lefaure Cc: Peter Huewe , Marcel Selhorst , Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm/tpm_crb: fix unused warnings on suspend/resume functions Message-ID: <20170321080353.oh2apppp37nchuw7@intel.com> References: <20170317015133.2269-1-jeremy.lefaure@lse.epita.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170317015133.2269-1-jeremy.lefaure@lse.epita.fr> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 16, 2017 at 09:51:33PM -0400, Jérémy Lefaure wrote: > When PM_SLEEP is disabled crb_pm_suspend and crb_pm_resume are not used by > SET_SYSTEM_SLEEP_PM_OPS even if PM is enabled: > > drvers/char/tpm/tpm_crb.c:540:12: warning: ‘crb_pm_suspend’ defined but not > used [-Wunused-function] > static int crb_pm_suspend(struct device *dev) > ^ > drivers/char/tpm/tpm_crb.c:551:12: warning: ‘crb_pm_resume’ defined but not > used [-Wunused-function] > static int crb_pm_resume(struct device *dev) > ^ > > The preprocessor condition should be on CONFIG_PM_SLEEP, not on CONFIG_PM. > However, this patch fixes this warning by using __maybe_unused on function > that are in the preprocessor condition. > > Signed-off-by: Jérémy Lefaure Thanks. Please include also linux-kernel@vger.kernel.org in the future. Reviewed-by: Jarkko Saskkinen /Jarkko > --- > drivers/char/tpm/tpm_crb.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c > index 324561845dc2..044afb73fdeb 100644 > --- a/drivers/char/tpm/tpm_crb.c > +++ b/drivers/char/tpm/tpm_crb.c > @@ -520,8 +520,7 @@ static int crb_acpi_remove(struct acpi_device *device) > return 0; > } > > -#ifdef CONFIG_PM > -static int crb_pm_runtime_suspend(struct device *dev) > +static int __maybe_unused crb_pm_runtime_suspend(struct device *dev) > { > struct tpm_chip *chip = dev_get_drvdata(dev); > struct crb_priv *priv = dev_get_drvdata(&chip->dev); > @@ -529,7 +528,7 @@ static int crb_pm_runtime_suspend(struct device *dev) > return crb_go_idle(dev, priv); > } > > -static int crb_pm_runtime_resume(struct device *dev) > +static int __maybe_unused crb_pm_runtime_resume(struct device *dev) > { > struct tpm_chip *chip = dev_get_drvdata(dev); > struct crb_priv *priv = dev_get_drvdata(&chip->dev); > @@ -537,7 +536,7 @@ static int crb_pm_runtime_resume(struct device *dev) > return crb_cmd_ready(dev, priv); > } > > -static int crb_pm_suspend(struct device *dev) > +static int __maybe_unused crb_pm_suspend(struct device *dev) > { > int ret; > > @@ -548,7 +547,7 @@ static int crb_pm_suspend(struct device *dev) > return crb_pm_runtime_suspend(dev); > } > > -static int crb_pm_resume(struct device *dev) > +static int __maybe_unused crb_pm_resume(struct device *dev) > { > int ret; > > @@ -559,8 +558,6 @@ static int crb_pm_resume(struct device *dev) > return tpm_pm_resume(dev); > } > > -#endif /* CONFIG_PM */ > - > static const struct dev_pm_ops crb_pm = { > SET_SYSTEM_SLEEP_PM_OPS(crb_pm_suspend, crb_pm_resume) > SET_RUNTIME_PM_OPS(crb_pm_runtime_suspend, crb_pm_runtime_resume, NULL) > -- > 2.12.0 >