From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: [PATCH v3 03/10] drm/fb-helper: Improve code readability Date: Tue, 21 Mar 2017 09:13:51 +0100 Message-ID: <20170321081358.27237-4-thierry.reding@gmail.com> References: <20170321081358.27237-1-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170321081358.27237-1-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org RnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KCkFkZCBhIGNvdXBsZSBv ZiB0ZW1wb3JhcnkgdmFyaWFibGVzIGFuZCB1c2Ugc2hvcnRlciBuYW1lcyBmb3IgZXhpc3RpbmcK dmFyaWFibGVzIGluIGRybV9mYl9oZWxwZXJfYWRkX29uZV9jb25uZWN0b3IoKSBmb3IgYmV0dGVy IHJlYWRhYmlsaXR5LgoKVGVzdGVkLWJ5OiBKb2huIFN0dWx0eiA8am9obi5zdHVsdHpAbGluYXJv Lm9yZz4KU2lnbmVkLW9mZi1ieTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4K LS0tCiBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIHwgMjUgKysrKysrKysrKysrKysr Ky0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKaW5kZXggODc1YTQ5MDQ4MjIyLi4xN2ZkOThmZTRh MWYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKKysrIGIvZHJp dmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwpAQCAtMTA5LDMxICsxMDksMzggQEAgc3RhdGlj IERFRklORV9NVVRFWChrZXJuZWxfZmJfaGVscGVyX2xvY2spOwogCWZvciAoKHsgbG9ja2RlcF9h c3NlcnRfaGVsZCgmKGZiaCktPmRldi0+bW9kZV9jb25maWcubXV0ZXgpOyB9KSwgXAogCSAgICAg aV9fID0gMDsgaV9fIDwgKGZiaCktPmNvbm5lY3Rvcl9jb3VudDsgaV9fKyspCiAKLWludCBkcm1f ZmJfaGVscGVyX2FkZF9vbmVfY29ubmVjdG9yKHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxw ZXIsIHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpCitpbnQgZHJtX2ZiX2hlbHBlcl9h ZGRfb25lX2Nvbm5lY3RvcihzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyLAorCQkJCSAg ICBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQogewogCXN0cnVjdCBkcm1fZmJfaGVs cGVyX2Nvbm5lY3RvciAqKnRlbXA7Ci0Jc3RydWN0IGRybV9mYl9oZWxwZXJfY29ubmVjdG9yICpm Yl9oZWxwZXJfY29ubmVjdG9yOworCXN0cnVjdCBkcm1fZmJfaGVscGVyX2Nvbm5lY3RvciAqY29u bjsKKwl1bnNpZ25lZCBpbnQgY291bnQ7CiAKIAlpZiAoIWRybV9mYmRldl9lbXVsYXRpb24pCiAJ CXJldHVybiAwOwogCiAJV0FSTl9PTighbXV0ZXhfaXNfbG9ja2VkKCZmYl9oZWxwZXItPmRldi0+ bW9kZV9jb25maWcubXV0ZXgpKTsKLQlpZiAoZmJfaGVscGVyLT5jb25uZWN0b3JfY291bnQgKyAx ID4gZmJfaGVscGVyLT5jb25uZWN0b3JfaW5mb19hbGxvY19jb3VudCkgewotCQl0ZW1wID0ga3Jl YWxsb2MoZmJfaGVscGVyLT5jb25uZWN0b3JfaW5mbywgc2l6ZW9mKHN0cnVjdCBkcm1fZmJfaGVs cGVyX2Nvbm5lY3RvciAqKSAqIChmYl9oZWxwZXItPmNvbm5lY3Rvcl9jb3VudCArIDEpLCBHRlBf S0VSTkVMKTsKKworCWNvdW50ID0gZmJfaGVscGVyLT5jb25uZWN0b3JfY291bnQgKyAxOworCisJ aWYgKGNvdW50ID4gZmJfaGVscGVyLT5jb25uZWN0b3JfaW5mb19hbGxvY19jb3VudCkgeworCQlz aXplX3Qgc2l6ZSA9IGNvdW50ICogc2l6ZW9mKGNvbm4pOworCisJCXRlbXAgPSBrcmVhbGxvYyhm Yl9oZWxwZXItPmNvbm5lY3Rvcl9pbmZvLCBzaXplLCBHRlBfS0VSTkVMKTsKIAkJaWYgKCF0ZW1w KQogCQkJcmV0dXJuIC1FTk9NRU07CiAKLQkJZmJfaGVscGVyLT5jb25uZWN0b3JfaW5mb19hbGxv Y19jb3VudCA9IGZiX2hlbHBlci0+Y29ubmVjdG9yX2NvdW50ICsgMTsKKwkJZmJfaGVscGVyLT5j b25uZWN0b3JfaW5mb19hbGxvY19jb3VudCA9IGNvdW50OwogCQlmYl9oZWxwZXItPmNvbm5lY3Rv cl9pbmZvID0gdGVtcDsKIAl9CiAKLQlmYl9oZWxwZXJfY29ubmVjdG9yID0ga3phbGxvYyhzaXpl b2Yoc3RydWN0IGRybV9mYl9oZWxwZXJfY29ubmVjdG9yKSwgR0ZQX0tFUk5FTCk7Ci0JaWYgKCFm Yl9oZWxwZXJfY29ubmVjdG9yKQorCWNvbm4gPSBremFsbG9jKHNpemVvZigqY29ubiksIEdGUF9L RVJORUwpOworCWlmICghY29ubikKIAkJcmV0dXJuIC1FTk9NRU07CiAKIAlkcm1fY29ubmVjdG9y X2dldChjb25uZWN0b3IpOwotCWZiX2hlbHBlcl9jb25uZWN0b3ItPmNvbm5lY3RvciA9IGNvbm5l Y3RvcjsKLQlmYl9oZWxwZXItPmNvbm5lY3Rvcl9pbmZvW2ZiX2hlbHBlci0+Y29ubmVjdG9yX2Nv dW50KytdID0gZmJfaGVscGVyX2Nvbm5lY3RvcjsKKwljb25uLT5jb25uZWN0b3IgPSBjb25uZWN0 b3I7CisJZmJfaGVscGVyLT5jb25uZWN0b3JfaW5mb1tmYl9oZWxwZXItPmNvbm5lY3Rvcl9jb3Vu dCsrXSA9IGNvbm47CiAJcmV0dXJuIDA7CiB9CiBFWFBPUlRfU1lNQk9MKGRybV9mYl9oZWxwZXJf YWRkX29uZV9jb25uZWN0b3IpOwotLSAKMi4xMi4wCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK