All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Vetter <daniel.vetter@intel.com>
Cc: John Stultz <john.stultz@linaro.org>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v3 07/10] drm/exynos: Remove custom FB helper deferred setup
Date: Tue, 21 Mar 2017 09:13:55 +0100	[thread overview]
Message-ID: <20170321081358.27237-8-thierry.reding@gmail.com> (raw)
In-Reply-To: <20170321081358.27237-1-thierry.reding@gmail.com>

From: Thierry Reding <treding@nvidia.com>

The FB helper core now supports deferred setup, so the driver's custom
implementation can be removed.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/exynos/exynos_drm_drv.c   | 6 ++++--
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 --
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index 09d3c4c3c858..c5a37dda8d1b 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -399,8 +399,9 @@ static int exynos_drm_bind(struct device *dev)
 	/* init kms poll for handling hpd */
 	drm_kms_helper_poll_init(drm);
 
-	/* force connectors detection */
-	drm_helper_hpd_irq_event(drm);
+	ret = exynos_drm_fbdev_init(dev);
+	if (ret)
+		goto err_cleanup_poll;
 
 	/* register the DRM device */
 	ret = drm_dev_register(drm, 0);
@@ -411,6 +412,7 @@ static int exynos_drm_bind(struct device *dev)
 
 err_cleanup_fbdev:
 	exynos_drm_fbdev_fini(drm);
+err_cleanup_poll:
 	drm_kms_helper_poll_fini(drm);
 	exynos_drm_device_subdrv_remove(drm);
 err_cleanup_vblank:
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index 641531243e04..a020fa70c825 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -306,6 +306,4 @@ void exynos_drm_output_poll_changed(struct drm_device *dev)
 
 	if (fb_helper)
 		drm_fb_helper_hotplug_event(fb_helper);
-	else
-		exynos_drm_fbdev_init(dev);
 }
-- 
2.12.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-03-21  8:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21  8:13 [PATCH v3 00/10] drm/fb-helper: Deferred setup support Thierry Reding
2017-03-21  8:13 ` [PATCH v3 01/10] drm/fb-helper: Cleanup checkpatch warnings Thierry Reding
2017-03-21  9:36   ` Daniel Vetter
2017-03-21  8:13 ` [PATCH v3 02/10] drm/fb-helper: Reshuffle code for subsequent patches Thierry Reding
2017-03-21  9:36   ` Daniel Vetter
2017-03-21  8:13 ` [PATCH v3 03/10] drm/fb-helper: Improve code readability Thierry Reding
2017-03-21  9:37   ` Daniel Vetter
2017-03-21  8:13 ` [PATCH v3 04/10] drm/fb-helper: Push down modeset lock into FB helpers Thierry Reding
2017-03-21  9:38   ` Daniel Vetter
2017-03-21  8:13 ` [PATCH v3 05/10] drm/fb-helper: Add top-level lock Thierry Reding
2017-03-21 10:00   ` Daniel Vetter
2017-03-21 10:15     ` Daniel Vetter
2017-03-21  8:13 ` [PATCH v3 06/10] drm/fb-helper: Support deferred setup Thierry Reding
2017-03-21 10:10   ` Daniel Vetter
2017-03-22 21:06     ` Thierry Reding
2017-03-22 21:08       ` Daniel Vetter
2017-04-03  8:48   ` Daniel Vetter
2017-03-21  8:13 ` Thierry Reding [this message]
2017-03-21  9:58   ` [PATCH v3 07/10] drm/exynos: Remove custom FB helper " Andrzej Hajda
2017-03-21 10:20     ` Daniel Vetter
2017-03-21 10:42       ` Andrzej Hajda
2017-03-21 10:53         ` Thierry Reding
2017-03-21 11:13           ` Andrzej Hajda
2017-03-21 11:17             ` Thierry Reding
2017-03-21 12:28             ` Daniel Vetter
2017-03-21  8:13 ` [PATCH v3 08/10] drm/hisilicon: " Thierry Reding
2017-03-21  8:13 ` [PATCH v3 09/10] drm/atmel-hlcdc: Remove unnecessary NULL check Thierry Reding
2017-03-21  8:13 ` [PATCH v3 10/10] drm/rockchip: " Thierry Reding
2017-03-21 10:27   ` Daniel Vetter
2017-03-21 11:13     ` Thierry Reding
2017-03-21  9:57 ` ✓ Fi.CI.BAT: success for drm/fb-helper: Deferred setup support (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170321081358.27237-8-thierry.reding@gmail.com \
    --to=thierry.reding@gmail.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=john.stultz@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.