From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org, Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH libnetfilter_cthelper] examples: fix double free in nftc-helper-add
Date: Tue, 21 Mar 2017 11:41:08 +0100 [thread overview]
Message-ID: <20170321104108.GA3034@salvia> (raw)
In-Reply-To: <1489932070-57299-1-git-send-email-zlpnobody@163.com>
On Sun, Mar 19, 2017 at 10:01:10PM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> After inputting the following test command, core dump happened:
> # ./examples/nfct-helper-add test 1
> *** Error in
> `.../libnetfilter_cthelper/examples/.libs/lt-nfct-helper-add':
> double free or corruption (fasttop): 0x0000000001f3c070 ***
> ======= Backtrace: =========
> /lib64/libc.so.6(+0x77de5)[0x7fd9ebe88de5]
> /lib64/libc.so.6(+0x8022a)[0x7fd9ebe9122a]
> /lib64/libc.so.6(cfree+0x4c)[0x7fd9ebe9478c]
> [...]
>
> Because "struct nfct_helper_policy *p" had been freed by nfct_helper_free,
> so there's no need to invoke nfct_helper_policy_free again, otherwise
> dobule free error will happen.
Applied, thanks.
prev parent reply other threads:[~2017-03-21 10:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-19 14:01 [PATCH libnetfilter_cthelper] examples: fix double free in nftc-helper-add Liping Zhang
2017-03-21 10:41 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321104108.GA3034@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.