From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v3 07/10] drm/exynos: Remove custom FB helper deferred setup Date: Tue, 21 Mar 2017 11:53:39 +0100 Message-ID: <20170321105339.GA30407@ulmo.ba.sec> References: <20170321081358.27237-1-thierry.reding@gmail.com> <20170321081358.27237-8-thierry.reding@gmail.com> <06a46f58-57b3-77e5-7434-8787981f0478@samsung.com> <20170321102049.w6dqxhu6nuudga4j@phenom.ffwll.local> <69858798-3b38-25e5-7624-e831d3d2ea32@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0279799682==" Return-path: In-Reply-To: <69858798-3b38-25e5-7624-e831d3d2ea32@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0279799682== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j" Content-Disposition: inline --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 21, 2017 at 11:42:21AM +0100, Andrzej Hajda wrote: > On 21.03.2017 11:20, Daniel Vetter wrote: > > On Tue, Mar 21, 2017 at 10:58:43AM +0100, Andrzej Hajda wrote: > >> On 21.03.2017 09:13, Thierry Reding wrote: > >>> From: Thierry Reding > >>> > >>> The FB helper core now supports deferred setup, so the driver's custom > >>> implementation can be removed. > >>> > >>> Signed-off-by: Thierry Reding > >>> --- > >>> drivers/gpu/drm/exynos/exynos_drm_drv.c | 6 ++++-- > >>> drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 -- > >>> 2 files changed, 4 insertions(+), 4 deletions(-) > >>> > >>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/dr= m/exynos/exynos_drm_drv.c > >>> index 09d3c4c3c858..c5a37dda8d1b 100644 > >>> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c > >>> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c > >>> @@ -399,8 +399,9 @@ static int exynos_drm_bind(struct device *dev) > >>> /* init kms poll for handling hpd */ > >>> drm_kms_helper_poll_init(drm); > >>> =20 > >>> - /* force connectors detection */ > >>> - drm_helper_hpd_irq_event(drm); > >>> + ret =3D exynos_drm_fbdev_init(dev); > >>> + if (ret) > >>> + goto err_cleanup_poll; > >> It should be rather: > >> ret =3D exynos_drm_fbdev_init(drm); > >> > >> Even with this change it does not work, I will try to track down the > >> problem. >=20 > The solution was to remove custom equivalent of > drm_fb_helper_maybe_connected - exynos_drm_fbdev_is_anything_connected, > it is called earlier and it was a part of custom deferred fbdev. Cool, thanks for figuring that out. I can add that to this patch for v4. > > We might need the multi-stage fbdev setup here, i.e. init fbdev, run > > hpd_irq_event() (I suspect that kicks all the connectors to start > > probing), then initial_config for fbdev. > > > > Probably simplest way to achieve this is to keep the hpd_irq_event call, > > but place it _after_ the fbdev_init. > > -Daniel >=20 > I wonder if it wouldn't be sufficient to check if there is anything > connected, instead of checking if there is anything not-disconnected, in > drm_fb_helper_maybe_connected. My recollection is that this had been discussed when I first sent this out. VGA outputs are somewhat of a special case in that you can't always properly detect that it's connected or not. So effectively we need to take into account the connector_status_unknown. There's also some more information about this in the kerneldoc for enum drm_connector_status. Thierry --nFreZHaLTZJo0R7j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAljRBjAACgkQ3SOs138+ s6Gjyw/+KhAesl4ImTHOrTx/b8zY4v7UbjasZoD5oN1rygjsPpKWDeFCeTYighLf m3BW1EA1X9DLW9vx3A/zm75Zm5rDPdc3Y+MHwMCpQAV9jUfLrX0QuKkiA2SE0w47 s2fLdQln3W7nhqvg3YBWRwHMr+3qTd/cc/a0ooR+AuiOLlurKy1774t94tpFDQT8 /pqxvWsx4A0DGa7xgYAhri08yADSYXiVsq6Lty8F6KbbXpcPFXA03RQETra6xM3Z OPUtlioINdPyoiUu8fJcq4OkL6vLSTMqeOZP9qFz9z0I8zMXCEinURqCnwWxLBc+ 2eTaW5bHEdMVR96QW19n+1HT4blvFA89HztDOEL3U7RdkuhbipeVPvkMxs2cyVLA /fJ9+yhGQcw3Pl1yV32Gg5Pu1V3k2tEuGDkD/Z/MFO8hhm5Yb6SVpy06KvmBp0Af lMXRN/Rh4hp2NY9jPSiPUM2mXfhdyYr9gZ0Toz7AquNrv12LccATnenfKiJxKxQh arTeIEWVkAjRWL1R31MC3HLt+nk2pzG3h+NYnc7t211Uee3XQBBDhcIfnsOuVJ48 2PJ1aWkKzgPgi2PpjYqzoHp7Dd9J62P562B6oFyUglW0JxjezgQZoJweJKHcrkds v4sJcp/ivLLAC1wT3PU68mtF0kmFwuhiQoD1ZdsdnehD9WPlgYY= =j063 -----END PGP SIGNATURE----- --nFreZHaLTZJo0R7j-- --===============0279799682== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0279799682==--