All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: kusumi.tomohiro@gmail.com
Cc: fio@vger.kernel.org, Tomohiro Kusumi <tkusumi@tuxera.com>
Subject: Re: [PATCH 1/7] Replace redundant TD_F_NOIO flag with td->io_ops_init
Date: Tue, 21 Mar 2017 07:16:28 -0600	[thread overview]
Message-ID: <20170321131628.GA16024@kernel.dk> (raw)
In-Reply-To: <20170320212847.71404-1-tkusumi@tuxera.com>

On Mon, Mar 20 2017, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
> 
> The only reason TD_F_NOIO exists in addition to FIO_NOIO is because
> fio_running_or_pending_io_threads() needs to know whether td has
> successfully initialized ioengine, whereas FIO_NOIO is statically
> set regardless of ioengines's ->init() result.
> 
> This commit adds a new td field ->io_ops_init to inidicate ->init()
> result, so that td needs no extra bit field for each ioengine like
> TD_F_NOIO. It was rather odd that td was unable to tell ->init()
> result afterward when ->init() failure (returning non zero) doesn't
> mean aborting fio itself. This commit also changes TD_F_NOIO to
> TD_F_RESERVED as it's no longer used.

Thanks, applied 1-7.

-- 
Jens Axboe



      parent reply	other threads:[~2017-03-21 13:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20 21:28 [PATCH 1/7] Replace redundant TD_F_NOIO flag with td->io_ops_init kusumi.tomohiro
2017-03-20 21:28 ` [PATCH 2/7] Define struct sk_out in server.h (not server.c) kusumi.tomohiro
2017-03-20 21:28 ` [PATCH 3/7] HOWTO: Mention cpuload= is mandatory for cpuio kusumi.tomohiro
2017-03-20 21:28 ` [PATCH 4/7] HOWTO: Mention fsync=/fsyncdata= are set to 0 by default kusumi.tomohiro
2017-03-20 21:28 ` [PATCH 5/7] Fix a comment after f227e2b6 kusumi.tomohiro
2017-03-20 21:28 ` [PATCH 6/7] Test uint,int before division uint/int for the next i/o kusumi.tomohiro
2017-03-20 21:28 ` [PATCH 7/7] Test fsync/fdatasync/sync_file_range for the next i/o only if should_fsync(td) kusumi.tomohiro
2017-03-21 13:16 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170321131628.GA16024@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=kusumi.tomohiro@gmail.com \
    --cc=tkusumi@tuxera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.