From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 5/6] syscalls: added memfd_create dir and memfd_create/memfd_create01.c
Date: Tue, 21 Mar 2017 16:27:11 +0100 [thread overview]
Message-ID: <20170321152711.GC32105@rei.lan> (raw)
In-Reply-To: <1489595740-26159-6-git-send-email-jracek@redhat.com>
Hi!
> .../syscalls/memfd_create/memfd_create_common.h | 457 +++++++++++++++++++++
Just a short question before further review, do you intend to write more
testcases that will use this header?
Since as it is the memfd_create02 needs only the memfd_new function and
the ASSERT that memfd_create() is implemented in kernel and including
that header in memfd_create02.c yields a few "unused function" warnings.
There are a couple of ways how to fix that but the easies solution would
be moving these functions into the memfd_create01.c in a case that
these are not needed for further testcases.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-03-21 15:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 16:35 [LTP] [PATCH v4 0/6] Added memfd_create() testsuite Jakub Racek
2017-03-15 16:35 ` [LTP] [PATCH v4 1/6] Added syscall numbers for memfd_create Jakub Racek
2017-03-15 16:35 ` [LTP] [PATCH v4 2/6] Added memfd_create() lapi flags Jakub Racek
2017-03-15 16:35 ` [LTP] [PATCH v4 3/6] Added fcntl() " Jakub Racek
2017-03-15 16:35 ` [LTP] [PATCH v4 4/6] move fallocate.h to lapi Jakub Racek
2017-03-15 16:35 ` [LTP] [PATCH v4 5/6] syscalls: added memfd_create dir and memfd_create/memfd_create01.c Jakub Racek
2017-03-21 15:27 ` Cyril Hrubis [this message]
2017-03-21 17:46 ` Jakub =?unknown-8bit?q?Ra=C4=8Dek?=
2017-03-22 10:19 ` Cyril Hrubis
2017-03-15 16:35 ` [LTP] [PATCH v4 6/6] syscalls/memfd_create02.c: added new test Jakub Racek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321152711.GC32105@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.