From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pascal Mazon Subject: Re: [PATCH v5 1/4] net/tap: move private elements to external header Date: Tue, 21 Mar 2017 17:57:52 +0100 Message-ID: <20170321175752.4e64e45a@paques.dev.6wind.com> References: <9176239A-AA15-49F2-AF81-FF9B58C9AF1D@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: "Wiles, Keith" Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 2157611C5 for ; Tue, 21 Mar 2017 17:58:02 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id n11so17244954wma.0 for ; Tue, 21 Mar 2017 09:58:02 -0700 (PDT) In-Reply-To: <9176239A-AA15-49F2-AF81-FF9B58C9AF1D@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 21 Mar 2017 15:32:06 +0000 "Wiles, Keith" wrote: > > Just noticed this new header does not have the C++ ifdefs. Create a > new patch to fix this problem, unless you need to update this patch > series. Just starting my review of this one, sorry was traveling last > week. > > Regards, > Keith > Hi Keith, rte_eth_tap.h header is only presenting functions for local use within the tap driver. That part of the code is completely internal to the driver, compiled as pure C, and is not to be used directly by the (potentially c++) user application linking itself with DPDK. It's thus normal to keep it standard C without the need for c++ ifdefs. The other PMDs in drivers/net also don't use the c++ ifdefs in their headers, by the way. Best regards, Pascal