From: Thierry Reding <thierry.reding@gmail.com>
To: Joao Pinto <Joao.Pinto@synopsys.com>
Cc: davem@davemloft.net, peppe.cavallaro@st.com,
alexandre.torgue@st.com, clabbe.montjoie@gmail.com,
sergei.shtylyov@cogentembedded.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: fix dma operation mode config for older versions
Date: Tue, 21 Mar 2017 21:46:47 +0100 [thread overview]
Message-ID: <20170321204644.GB1064@mithrandir.ba.sec> (raw)
In-Reply-To: <3b8aeab69d2987db68c74f48a3ac13c7241e1542.1490118934.git.jpinto@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
Resending with Sergei's proper email address.
On Tue, Mar 21, 2017 at 06:02:36PM +0000, Joao Pinto wrote:
> This patch fixes a bug introduced in:
> commit 6deee2221e11 ("net: stmmac: prepare dma op mode config for multiple
> queues")
>
> The dma operation mode configuration routine was wrongly moved to a
> function (stmmac_mtl_configuration) that is only executed if the
> core version is >= 4.00.
>
> Reported-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
With Florian's comments addressed, this is:
Reviewed-by: Thierry Reding <thierry.reding@gmail.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-03-21 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 18:00 [PATCH v2 net-next] net: fix dma operation mode config for older versions Joao Pinto
2017-03-21 18:56 ` Florian Fainelli
2017-03-22 11:07 ` Joao Pinto
2017-03-21 20:42 ` Thierry Reding
2017-03-21 20:46 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321204644.GB1064@mithrandir.ba.sec \
--to=thierry.reding@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.