From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] vhost: remove a hack on queue allocation
Date: Wed, 22 Mar 2017 16:56:12 +0800
Message-ID: <20170322085612.GP18844@yliu-dev.sh.intel.com>
References: <1488434385-7605-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1488435367-22170-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1042e46c-733f-929d-b299-9ac7abf174cb@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id C05DE11C5
 for <dev@dpdk.org>; Wed, 22 Mar 2017 09:58:23 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1042e46c-733f-929d-b299-9ac7abf174cb@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Mar 22, 2017 at 09:41:07AM +0100, Maxime Coquelin wrote:
> 
> 
> On 03/02/2017 07:16 AM, Yuanhan Liu wrote:
> >We used to allocate queues based on the index from SET_VRING_CALL
> >request: if corresponding queue hasn't been allocated, allocate it.
> >
> >Though it's pratically right (it's the first per-vring request we
> >will get from QEMU for vhost-user negotiation), but it's not technically
> >right: it's not documented in the vhost-user spec that it will always
> >be the first per-vring request. For example, SET_VRING_ADDR could also
> >be the first per-vring request.
> >
> >Thus, we should not depend the SET_VRING_CALL on queue allocation.
> >Instead, we could catch all the per-vring messages at the entrance of
> >request handler, and allocate one if it hasn't been allocated before.
> >
> >By that, we could remove a hack.
> >
> >Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >---
> >
> >v2: add missing break
> >---
> > lib/librte_vhost/vhost_user.c | 61 ++++++++++++++++++++++++++++++++++---------
> > 1 file changed, 48 insertions(+), 13 deletions(-)
> 
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks.

Applied to dpdk-next-virtio.

	--yliu