From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [RFC PATCH 2/3] drm/panel: sharp-lq101r1sx01: Use panel-common helpers Date: Wed, 22 Mar 2017 10:16:18 -0400 Message-ID: <20170322141618.GO19389@art_vandelay> References: <20170316220837.17347-1-seanpaul@chromium.org> <20170316220837.17347-3-seanpaul@chromium.org> <87poha1grx.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk0-x232.google.com (mail-qk0-x232.google.com [IPv6:2607:f8b0:400d:c09::232]) by gabe.freedesktop.org (Postfix) with ESMTPS id 79F45890F9 for ; Wed, 22 Mar 2017 14:16:21 +0000 (UTC) Received: by mail-qk0-x232.google.com with SMTP id p64so158120949qke.1 for ; Wed, 22 Mar 2017 07:16:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87poha1grx.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXIgMjEsIDIwMTcgYXQgMDI6MDY6MjZQTSAtMDcwMCwgRXJpYyBBbmhvbHQgd3Jv dGU6Cj4gU2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+IHdyaXRlczoKPiAKPiA+IElu c3RlYWQgb2YgZHVwbGljYXRpbmcgY29tbW9uIGNvZGUgZnJvbSBwYW5lbC1zaW1wbGUsIHVzZSB0 aGUgcGFuZWwtY29tbW9uIGhlbHBlcnMuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogU2VhbiBQYXVs IDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vcGFu ZWwvS2NvbmZpZyAgICAgICAgICAgICAgICAgICB8ICAxICsKPiA+ICBkcml2ZXJzL2dwdS9kcm0v cGFuZWwvcGFuZWwtc2hhcnAtbHExMDFyMXN4MDEuYyB8IDc5ICsrKysrKystLS0tLS0tLS0tLS0t LS0tLS0KPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDU2IGRlbGV0aW9u cygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvS2NvbmZpZyBi L2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9LY29uZmlnCj4gPiBpbmRleCBiZTg1OTA3MjQwNDIuLjk4 ZGI3OGQyMmExMyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9LY29uZmln Cj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvS2NvbmZpZwo+ID4gQEAgLTczLDYgKzcz LDcgQEAgY29uZmlnIERSTV9QQU5FTF9TSEFSUF9MUTEwMVIxU1gwMQo+ID4gIAlkZXBlbmRzIG9u IE9GCj4gPiAgCWRlcGVuZHMgb24gRFJNX01JUElfRFNJCj4gPiAgCWRlcGVuZHMgb24gQkFDS0xJ R0hUX0NMQVNTX0RFVklDRQo+ID4gKwlzZWxlY3QgRFJNX1BBTkVMX0NPTU1PTgo+ID4gIAloZWxw Cj4gPiAgCSAgU2F5IFkgaGVyZSBpZiB5b3Ugd2FudCB0byBlbmFibGUgc3VwcG9ydCBmb3IgU2hh cnAgTFExMDFSMVNYMDEKPiA+ICAJICBURlQtTENEIG1vZHVsZXMuIFRoZSBwYW5lbCBoYXMgYSAy NTYweDE2MDAgcmVzb2x1dGlvbiBhbmQgdXNlcwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9wYW5lbC9wYW5lbC1zaGFycC1scTEwMXIxc3gwMS5jIGIvZHJpdmVycy9ncHUvZHJtL3Bh bmVsL3BhbmVsLXNoYXJwLWxxMTAxcjFzeDAxLmMKPiA+IGluZGV4IDNjY2UzY2ExOTYwMS4uZmIy YmY2NzQ0OWFiIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNo YXJwLWxxMTAxcjFzeDAxLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1z aGFycC1scTEwMXIxc3gwMS5jCj4gPiBAQCAtNiwxMSArNiw4IEBACj4gPiAgICogcHVibGlzaGVk IGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24uCj4gPiAgICovCj4gPiAgCj4gPiAtI2lu Y2x1ZGUgPGxpbnV4L2JhY2tsaWdodC5oPgo+ID4gLSNpbmNsdWRlIDxsaW51eC9ncGlvL2NvbnN1 bWVyLmg+Cj4gPiAgI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+ID4gICNpbmNsdWRlIDxsaW51 eC9vZi5oPgo+ID4gLSNpbmNsdWRlIDxsaW51eC9yZWd1bGF0b3IvY29uc3VtZXIuaD4KPiA+ICAK PiA+ICAjaW5jbHVkZSA8ZHJtL2RybVAuaD4KPiA+ICAjaW5jbHVkZSA8ZHJtL2RybV9jcnRjLmg+ Cj4gPiBAQCAtMTksMTcgKzE2LDE3IEBACj4gPiAgCj4gPiAgI2luY2x1ZGUgPHZpZGVvL21pcGlf ZGlzcGxheS5oPgo+ID4gIAo+ID4gKyNpbmNsdWRlICJwYW5lbC1jb21tb24uaCIKPiA+ICsKPiA+ ICBzdHJ1Y3Qgc2hhcnBfcGFuZWwgewo+ID4gIAlzdHJ1Y3QgZHJtX3BhbmVsIGJhc2U7Cj4gPiAr CXN0cnVjdCBwYW5lbF9jb21tb24gY29tbW9uOwo+ID4gKwo+ID4gIAkvKiB0aGUgZGF0YXNoZWV0 IHJlZmVycyB0byB0aGVtIGFzIERTSS1MSU5LMSBhbmQgRFNJLUxJTksyICovCj4gPiAgCXN0cnVj dCBtaXBpX2RzaV9kZXZpY2UgKmxpbmsxOwo+ID4gIAlzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlICps aW5rMjsKPiA+ICAKPiA+IC0Jc3RydWN0IGJhY2tsaWdodF9kZXZpY2UgKmJhY2tsaWdodDsKPiA+ IC0Jc3RydWN0IHJlZ3VsYXRvciAqc3VwcGx5Owo+ID4gLQo+ID4gIAlib29sIHByZXBhcmVkOwo+ ID4gLQlib29sIGVuYWJsZWQ7Cj4gPiAgCj4gPiAgCWNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9t b2RlICptb2RlOwo+ID4gIH07Cj4gPiBAQCAtOTMsMTcgKzkwLDcgQEAgc3RhdGljIGludCBzaGFy cF9wYW5lbF9kaXNhYmxlKHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsKQo+ID4gIHsKPiA+ICAJc3Ry dWN0IHNoYXJwX3BhbmVsICpzaGFycCA9IHRvX3NoYXJwX3BhbmVsKHBhbmVsKTsKPiA+ICAKPiA+ IC0JaWYgKCFzaGFycC0+ZW5hYmxlZCkKPiA+IC0JCXJldHVybiAwOwo+ID4gLQo+ID4gLQlpZiAo c2hhcnAtPmJhY2tsaWdodCkgewo+ID4gLQkJc2hhcnAtPmJhY2tsaWdodC0+cHJvcHMucG93ZXIg PSBGQl9CTEFOS19QT1dFUkRPV047Cj4gPiAtCQliYWNrbGlnaHRfdXBkYXRlX3N0YXR1cyhzaGFy cC0+YmFja2xpZ2h0KTsKPiA+IC0JfQo+ID4gLQo+ID4gLQlzaGFycC0+ZW5hYmxlZCA9IGZhbHNl Owo+ID4gLQo+ID4gLQlyZXR1cm4gMDsKPiA+ICsJcmV0dXJuIHBhbmVsX2NvbW1vbl9kaXNhYmxl KCZzaGFycC0+Y29tbW9uLCAwKTsKPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIGludCBzaGFycF9w YW5lbF91bnByZXBhcmUoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpCj4gPiBAQCAtMTI2LDExICsx MTMsMTMgQEAgc3RhdGljIGludCBzaGFycF9wYW5lbF91bnByZXBhcmUoc3RydWN0IGRybV9wYW5l bCAqcGFuZWwpCj4gPiAgCj4gPiAgCW1zbGVlcCgxMjApOwo+ID4gIAo+ID4gLQlyZWd1bGF0b3Jf ZGlzYWJsZShzaGFycC0+c3VwcGx5KTsKPiA+ICsJZXJyID0gcGFuZWxfY29tbW9uX3VucHJlcGFy ZSgmc2hhcnAtPmNvbW1vbiwgMCk7Cj4gPiArCWlmIChlcnIgPCAwKQo+ID4gKwkJZGV2X2Vycihw YW5lbC0+ZGV2LCAiZmFpbGVkIGNvbW1vbiB1bnByZXBhcmU6ICVkXG4iLCBlcnIpOwo+ID4gIAo+ ID4gIAlzaGFycC0+cHJlcGFyZWQgPSBmYWxzZTsKPiA+ICAKPiA+IC0JcmV0dXJuIDA7Cj4gPiAr CXJldHVybiBlcnI7Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyBpbnQgc2hhcnBfc2V0dXBfc3lt bWV0cmljYWxfc3BsaXQoc3RydWN0IG1pcGlfZHNpX2RldmljZSAqbGVmdCwKPiA+IEBAIC0xNzYs MTcgKzE2NSwxNSBAQCBzdGF0aWMgaW50IHNoYXJwX3BhbmVsX3ByZXBhcmUoc3RydWN0IGRybV9w YW5lbCAqcGFuZWwpCj4gPiAgCWlmIChzaGFycC0+cHJlcGFyZWQpCj4gPiAgCQlyZXR1cm4gMDsK PiA+ICAKPiA+IC0JZXJyID0gcmVndWxhdG9yX2VuYWJsZShzaGFycC0+c3VwcGx5KTsKPiA+IC0J aWYgKGVyciA8IDApCj4gPiAtCQlyZXR1cm4gZXJyOwo+ID4gLQo+ID4gIAkvKgo+ID4gIAkgKiBB Y2NvcmRpbmcgdG8gdGhlIGRhdGFzaGVldCwgdGhlIHBhbmVsIG5lZWRzIGFyb3VuZCAxMCBtcyB0 byBmdWxseQo+ID4gIAkgKiBwb3dlciB1cC4gQXQgbGVhc3QgYW5vdGhlciAxMjAgbXMgaXMgcmVx dWlyZWQgYmVmb3JlIGV4aXRpbmcgc2xlZXAKPiA+ICAJICogbW9kZSB0byBtYWtlIHN1cmUgdGhl IHBhbmVsIGlzIHJlYWR5LiBUaHJvdyBpbiBhbm90aGVyIDIwIG1zIGZvcgo+ID4gIAkgKiBnb29k IG1lYXN1cmUuCj4gPiAgCSAqLwo+ID4gLQltc2xlZXAoMTUwKTsKPiA+ICsJZXJyID0gcGFuZWxf Y29tbW9uX3ByZXBhcmUoJnNoYXJwLT5jb21tb24sIDE1MCk7Cj4gPiArCWlmIChlcnIgPCAwKQo+ ID4gKwkJcmV0dXJuIGVycjsKPiAKPiBBc2lkZTogSSBsaWtlIGhvdyAxMjAgKyAyMCA9IDE1MCwg YmVjYXVzZSBhbHdheXMgcm91bmQgdXAgeW91ciBkZWxheXMgOikKCllvdSBtaXNzZWQgdGhlIGlu aXRpYWwgMTBtcyB0byAiZnVsbHkgcG93ZXIgdXAiLCBzbyBpdCdzIDEwICsgMTIwICsgMjAgPSAx NTAKVGhhdCBzYWlkLCB5b3UgY2FuIG5ldmVyIGhhdmUgZW5vdWdoIGZ1ZGdlIGluIHlvdXIgZGVs YXlzIDotKQoKPiAKPiA+ICAKPiA+ICAJZXJyID0gbWlwaV9kc2lfZGNzX2V4aXRfc2xlZXBfbW9k ZShzaGFycC0+bGluazEpOwo+ID4gIAlpZiAoZXJyIDwgMCkgewo+ID4gQEAgLTI1Miw3ICsyMzks NyBAQCBzdGF0aWMgaW50IHNoYXJwX3BhbmVsX3ByZXBhcmUoc3RydWN0IGRybV9wYW5lbCAqcGFu ZWwpCj4gPiAgCXJldHVybiAwOwo+ID4gIAo+ID4gIHBvd2Vyb2ZmOgo+ID4gLQlyZWd1bGF0b3Jf ZGlzYWJsZShzaGFycC0+c3VwcGx5KTsKPiA+ICsJcGFuZWxfY29tbW9uX3VucHJlcGFyZSgmc2hh cnAtPmNvbW1vbiwgMCk7Cj4gPiAgCXJldHVybiBlcnI7Cj4gPiAgfQo+ID4gIAo+ID4gQEAgLTI2 MCwxNyArMjQ3LDcgQEAgc3RhdGljIGludCBzaGFycF9wYW5lbF9lbmFibGUoc3RydWN0IGRybV9w YW5lbCAqcGFuZWwpCj4gPiAgewo+ID4gIAlzdHJ1Y3Qgc2hhcnBfcGFuZWwgKnNoYXJwID0gdG9f c2hhcnBfcGFuZWwocGFuZWwpOwo+ID4gIAo+ID4gLQlpZiAoc2hhcnAtPmVuYWJsZWQpCj4gPiAt CQlyZXR1cm4gMDsKPiA+IC0KPiA+IC0JaWYgKHNoYXJwLT5iYWNrbGlnaHQpIHsKPiA+IC0JCXNo YXJwLT5iYWNrbGlnaHQtPnByb3BzLnBvd2VyID0gRkJfQkxBTktfVU5CTEFOSzsKPiA+IC0JCWJh Y2tsaWdodF91cGRhdGVfc3RhdHVzKHNoYXJwLT5iYWNrbGlnaHQpOwo+ID4gLQl9Cj4gPiAtCj4g PiAtCXNoYXJwLT5lbmFibGVkID0gdHJ1ZTsKPiA+IC0KPiA+IC0JcmV0dXJuIDA7Cj4gPiArCXJl dHVybiBwYW5lbF9jb21tb25fZW5hYmxlKCZzaGFycC0+Y29tbW9uLCAwKTsKPiA+ICB9Cj4gPiAg Cj4gPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlIGRlZmF1bHRfbW9kZSA9 IHsKPiA+IEBAIC0zMjQsMjMgKzMwMSwxNSBAQCBNT0RVTEVfREVWSUNFX1RBQkxFKG9mLCBzaGFy cF9vZl9tYXRjaCk7Cj4gPiAgCj4gPiAgc3RhdGljIGludCBzaGFycF9wYW5lbF9hZGQoc3RydWN0 IHNoYXJwX3BhbmVsICpzaGFycCkKPiA+ICB7Cj4gPiAtCXN0cnVjdCBkZXZpY2Vfbm9kZSAqbnA7 Cj4gPiAgCWludCBlcnI7Cj4gPiAgCj4gPiAgCXNoYXJwLT5tb2RlID0gJmRlZmF1bHRfbW9kZTsK PiA+ICsJc2hhcnAtPnByZXBhcmVkID0gZmFsc2U7Cj4gPiAgCj4gPiAtCXNoYXJwLT5zdXBwbHkg PSBkZXZtX3JlZ3VsYXRvcl9nZXQoJnNoYXJwLT5saW5rMS0+ZGV2LCAicG93ZXIiKTsKPiA+IC0J aWYgKElTX0VSUihzaGFycC0+c3VwcGx5KSkKPiA+IC0JCXJldHVybiBQVFJfRVJSKHNoYXJwLT5z dXBwbHkpOwo+ID4gLQo+ID4gLQlucCA9IG9mX3BhcnNlX3BoYW5kbGUoc2hhcnAtPmxpbmsxLT5k ZXYub2Zfbm9kZSwgImJhY2tsaWdodCIsIDApOwo+ID4gLQlpZiAobnApIHsKPiA+IC0JCXNoYXJw LT5iYWNrbGlnaHQgPSBvZl9maW5kX2JhY2tsaWdodF9ieV9ub2RlKG5wKTsKPiA+IC0JCW9mX25v ZGVfcHV0KG5wKTsKPiA+IC0KPiA+IC0JCWlmICghc2hhcnAtPmJhY2tsaWdodCkKPiA+IC0JCQly ZXR1cm4gLUVQUk9CRV9ERUZFUjsKPiA+IC0JfQo+ID4gKwllcnIgPSBwYW5lbF9jb21tb25faW5p dCgmc2hhcnAtPmxpbmsxLT5kZXYsICZzaGFycC0+Y29tbW9uLCAic3VwcGx5IiwKPiA+ICsJCQkJ ImdwaW8iLCAiYmFja2xpZ2h0Iik7Cj4gPiArCWlmIChlcnIgPCAwKQo+ID4gKwkJcmV0dXJuIGVy cjsKPiAKPiBMb29rcyBsaWtlIHlvdSd2ZSBpbmNpZGVudGFsbHkgY2hhbmdlZCB0aGUgcmVndWxh dG9yIG5hbWUgZnJvbSAicG93ZXIiCj4gdG8gInN1cHBseSIuICBTZWVtcyBsaWtlIGl0IHNob3Vs ZCBiZSBhIGNhbGxlZCBvdXQgaW4gdGhlIGNvbW1pdAo+IG1lc3NhZ2UsIGlmIGludGVudGlvbmFs LgoKT2ggbXksIHllcyBJIGRpZCwgdGhhbmtzIGZvciBjYXRjaGluZyB0aGF0LiBJJ2xsIGZpeCB0 aGlzIHVwIGxvY2FsbHkgYW5kIHdhaXQKZm9yIFRoaWVycnkgdG8gd2VpZ2ggaW4gYmVmb3JlIHBv c3RpbmcgYSB2Mi4KClNlYW4KCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBHb29n bGUgLyBDaHJvbWl1bSBPUwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK