From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: kbuild test robot <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>,
kbuild-all-JC7UmRfGjtg@public.gmane.org
Subject: Re: [iommu:core 3/3] drivers/iommu/iova.c:36: error: redefinition of 'init_iova_domain'
Date: Wed, 22 Mar 2017 19:36:52 +0100 [thread overview]
Message-ID: <20170322183651.GA27374@ulmo.ba.sec> (raw)
In-Reply-To: <201703230212.uKXA27d6%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 3531 bytes --]
On Thu, Mar 23, 2017 at 02:28:27AM +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git core
> head: 21aff52ab2c831c2f07d48e2fa8d4bab26a66992
> commit: 21aff52ab2c831c2f07d48e2fa8d4bab26a66992 [3/3] iommu: Add dummy implementations for !IOMMU_IOVA
> config: x86_64-randconfig-a0-03222342 (attached as .config)
> compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
> reproduce:
> git checkout 21aff52ab2c831c2f07d48e2fa8d4bab26a66992
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> >> drivers/iommu/iova.c:36: error: redefinition of 'init_iova_domain'
> include/linux/iova.h:170: note: previous definition of 'init_iova_domain' was here
> >> drivers/iommu/iova.c:202: error: redefinition of 'alloc_iova_mem'
> include/linux/iova.h:120: note: previous definition of 'alloc_iova_mem' was here
> >> drivers/iommu/iova.c:208: error: redefinition of 'free_iova_mem'
> include/linux/iova.h:125: note: previous definition of 'free_iova_mem' was here
> >> drivers/iommu/iova.c:214: error: redefinition of 'iova_cache_get'
> include/linux/iova.h:111: note: previous definition of 'iova_cache_get' was here
> >> drivers/iommu/iova.c:235: error: redefinition of 'iova_cache_put'
> include/linux/iova.h:116: note: previous definition of 'iova_cache_put' was here
> >> drivers/iommu/iova.c:261: error: redefinition of 'alloc_iova'
> include/linux/iova.h:137: note: previous definition of 'alloc_iova' was here
> >> drivers/iommu/iova.c:323: error: redefinition of 'find_iova'
> include/linux/iova.h:177: note: previous definition of 'find_iova' was here
> >> drivers/iommu/iova.c:343: error: redefinition of '__free_iova'
> include/linux/iova.h:133: note: previous definition of '__free_iova' was here
> >> drivers/iommu/iova.c:361: error: redefinition of 'free_iova'
> include/linux/iova.h:129: note: previous definition of 'free_iova' was here
> >> drivers/iommu/iova.c:380: error: redefinition of 'alloc_iova_fast'
> include/linux/iova.h:151: note: previous definition of 'alloc_iova_fast' was here
> >> drivers/iommu/iova.c:421: error: redefinition of 'free_iova_fast'
> include/linux/iova.h:145: note: previous definition of 'free_iova_fast' was here
> >> drivers/iommu/iova.c:435: error: redefinition of 'put_iova_domain'
> include/linux/iova.h:183: note: previous definition of 'put_iova_domain' was here
> >> drivers/iommu/iova.c:511: error: redefinition of 'reserve_iova'
> include/linux/iova.h:158: note: previous definition of 'reserve_iova' was here
> >> drivers/iommu/iova.c:552: error: redefinition of 'copy_reserved_iova'
> include/linux/iova.h:165: note: previous definition of 'copy_reserved_iova' was here
> >> drivers/iommu/iova.c:572: error: redefinition of 'split_and_remove_iova'
> include/linux/iova.h:187: note: previous definition of 'split_and_remove_iova' was here
> >> drivers/iommu/iova.c:887: error: redefinition of 'free_cpu_cached_iovas'
> include/linux/iova.h:195: note: previous definition of 'free_cpu_cached_iovas' was here
*sigh* I think I messed up the #ifdef line. The attached .config has
CONFIG_IOMMU_IOVA=m, which means that the #ifdef won't be true. I think
the proper fix would be to:
-#ifdef CONFIG_IOMMU_IOVA
+#ifdef IS_ENABLED(CONFIG_IOMMU_IOVA)
Joerg, can you fix that up yourself or do you want me to resend the
patch with the fix rolled in?
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2017-03-22 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 18:28 [iommu:core 3/3] drivers/iommu/iova.c:36: error: redefinition of 'init_iova_domain' kbuild test robot
[not found] ` <201703230212.uKXA27d6%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-03-22 18:36 ` Thierry Reding [this message]
[not found] ` <20170322183651.GA27374-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2017-03-22 21:57 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322183651.GA27374@ulmo.ba.sec \
--to=treding-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jroedel-l3A5Bk7waGM@public.gmane.org \
--cc=kbuild-all-JC7UmRfGjtg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.