Re: [PATCH 3/3] ACPI: Don't create a platform_device for IOAPIC/IOxAPIC

[Joerg Roedel <jroedel@suse.de>]

Hi Rafael,

On Wed, Mar 22, 2017 at 06:42:39PM +0100, Rafael J. Wysocki wrote:
> On Wednesday, March 22, 2017 06:33:25 PM Joerg Roedel wrote:
> > From: Joerg Roedel <jroedel@suse.de>
> > 
> > No platform-device is required for IO(x)APICs, so don't even
> > create them.
> > 
> > Signed-off-by: Joerg Roedel <jroedel@suse.de>
> 
> If we do this, I'd prefer not to do [2/3], because we'll introduce code that
> will be essentially dead then.

In this case the code in acpi_bus_attach() adding platform_devices is also
dead. Could it be removed then?

> 
> > ---
> >  drivers/acpi/acpi_platform.c | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> > index b4c1a6a..03250e1 100644
> > --- a/drivers/acpi/acpi_platform.c
> > +++ b/drivers/acpi/acpi_platform.c
> > @@ -25,9 +25,11 @@
> >  ACPI_MODULE_NAME("platform");
> >  
> >  static const struct acpi_device_id forbidden_id_list[] = {
> > -	{"PNP0000", 0},	/* PIC */
> > -	{"PNP0100", 0},	/* Timer */
> > -	{"PNP0200", 0},	/* AT DMA Controller */
> 
> Why do you change the existing entries?

Just to align the '0's in one column :)


	Joerg