From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753319AbdCWHci (ORCPT ); Thu, 23 Mar 2017 03:32:38 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42010 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013AbdCWHcC (ORCPT ); Thu, 23 Mar 2017 03:32:02 -0400 Date: Thu, 23 Mar 2017 08:23:23 +0100 From: Greg Kroah-Hartman To: Pushkar Jambhlekar Cc: Lidza Louina , Mark Hounschell , driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/staging/dgnc: Updating dev_dbg function Message-ID: <20170323072323.GA1283@kroah.com> References: <1490168877-20551-1-git-send-email-pushkar.iit@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490168877-20551-1-git-send-email-pushkar.iit@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2017 at 01:17:57PM +0530, Pushkar Jambhlekar wrote: > Making use of __func__ instead of using function name directly in dev_dbg. > > Signed-off-by: Pushkar Jambhlekar > --- > drivers/staging/dgnc/dgnc_tty.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c > index f7e754e..b0c88b8 100644 > --- a/drivers/staging/dgnc/dgnc_tty.c > +++ b/drivers/staging/dgnc/dgnc_tty.c > @@ -1858,13 +1858,13 @@ static void dgnc_tty_send_xchar(struct tty_struct *tty, char c) > if (!bd || bd->magic != DGNC_BOARD_MAGIC) > return; > > - dev_dbg(tty->dev, "dgnc_tty_send_xchar start\n"); > + dev_dbg(tty->dev, "%s start\n", __func__); As I stated on the mailing list a few days ago, these lines need to just be deleted entirely, as we have ftrace to help with this type of thing. thanks, greg k-h