All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Linus Walleij
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Mathias Duckeck
	<m.duckeck-XB/JSsFECOqzQB+pC5nmwQ@public.gmane.org>,
	linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
Subject: Re: [PATCH 2/2] spi: bcm2835: Allow platform to set realtime priority
Date: Thu, 23 Mar 2017 14:43:36 +0100	[thread overview]
Message-ID: <20170323134336.GA10576@h08.hostsharing.net> (raw)
In-Reply-To: <20170323122118.i2gc77debz4eu5hq-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>

On Thu, Mar 23, 2017 at 12:21:18PM +0000, Mark Brown wrote:
> > Also, if you question setting the RT priority in the devicetree, why
> > was that functionality allowed for pl022 in the first place?
> 
> This was being done via platform data not via device tree, unlike
> platform data device tree should provide a long term stable OS neutral
> ABI.

No, specifying it via the device tree was subsequently added with
commit 39a6ac11df65 ("spi/pl022: Devicetree support w/o platform data"),
sorry for not mentioning this in the commit message.

There's already a bool in struct spi_master for this functionality and
device tree support for pl022, so I don't quite understand why converting
the bool to an int and adding device tree support for bcm2835 would be
the wrong approach?

Thanks,

Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-03-23 13:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23 10:36 [PATCH 1/2] spi: Allow master drivers to set realtime priority Lukas Wunner
     [not found] ` <c1ca8a5522272d06f5c3fb67d8442f148b2d6cfb.1490264661.git.lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2017-03-23 10:36   ` [PATCH 2/2] spi: bcm2835: Allow platform " Lukas Wunner
     [not found]     ` <1503363fcfb92adfa765d1c1c3e69fc673e72dde.1490264661.git.lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2017-03-23 10:51       ` Alexander Stein
2017-03-23 11:24         ` Lukas Wunner
2017-03-23 11:07       ` Mark Brown
     [not found]         ` <20170323110718.sncw32gspvls75u7-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-03-23 12:02           ` Lukas Wunner
     [not found]             ` <20170323120257.GC20546-KMaqurgeqYRAE5l8fViCMtHuzzzSOjJt@public.gmane.org>
2017-03-23 12:21               ` Mark Brown
     [not found]                 ` <20170323122118.i2gc77debz4eu5hq-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-03-23 13:43                   ` Lukas Wunner [this message]
     [not found]                     ` <20170323134336.GA10576-KMaqurgeqYRAE5l8fViCMtHuzzzSOjJt@public.gmane.org>
2017-03-23 13:48                       ` Linus Walleij
     [not found]                         ` <CACRpkdY2QKLNbW_+i=qBCYr8iOHckYmukePOHUHtVpdW5xpjWw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-23 14:28                           ` Lukas Wunner
     [not found]                             ` <20170323142816.GA19878-KMaqurgeqYRAE5l8fViCMtHuzzzSOjJt@public.gmane.org>
2017-03-23 16:02                               ` Mark Brown
2017-03-23 15:46                       ` Mark Brown
2017-03-23 14:08                   ` kernel-TqfNSX0MhmxHKSADF0wUEw
     [not found]                     ` <36CAED84-34BB-43E8-8716-0187F3B7EFE0-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2017-03-23 16:22                       ` Mark Brown
2017-03-23 13:00               ` Linus Walleij
2017-03-23 16:33       ` Stefan Wahren
     [not found]         ` <a5439023-c268-996a-dfa2-1325c201cb25-eS4NqCHxEME@public.gmane.org>
2017-03-24 16:10           ` Lukas Wunner
2017-03-23 13:10   ` [PATCH 1/2] spi: Allow master drivers " Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170323134336.GA10576@h08.hostsharing.net \
    --to=lukas-jfq808j9c/izqb+pc5nmwq@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org \
    --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=m.duckeck-XB/JSsFECOqzQB+pC5nmwQ@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.