From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 for-2.10 0/4] block: Add errp to b{lk, drv}_truncate()
Date: Thu, 23 Mar 2017 19:05:23 +0100 [thread overview]
Message-ID: <20170323180523.GF5344@noname.redhat.com> (raw)
In-Reply-To: <20170308191434.2413-1-mreitz@redhat.com>
Am 08.03.2017 um 20:14 hat Max Reitz geschrieben:
> Having an Error parameter for these functions makes sense because we
> sometimes want a bit more information than just "Something failed". Some
> drivers already use error_report() and the like to emit this additional
> information, so it's rather obvious that we do want a real error object
> here.
I had only some minor comments about improving one error message or
another, so whether you fix them or not:
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
(But if you don't fix them, you need to merge the patches yourself)
next prev parent reply other threads:[~2017-03-23 18:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 19:14 [Qemu-devel] [PATCH v2 for-2.10 0/4] block: Add errp to b{lk, drv}_truncate() Max Reitz
2017-03-08 19:14 ` [Qemu-devel] [PATCH v2 for-2.10 1/4] block/vhdx: Make vhdx_create() always set errp Max Reitz
2017-03-08 19:14 ` [Qemu-devel] [PATCH v2 for-2.10 2/4] block: Add errp to b{lk, drv}_truncate() Max Reitz
2017-03-23 17:46 ` Kevin Wolf
2017-03-28 19:34 ` Max Reitz
2017-03-08 19:15 ` [Qemu-devel] [PATCH v2 for-2.10 3/4] block: Add errp to BD.bdrv_truncate() Max Reitz
2017-03-23 18:00 ` Kevin Wolf
2017-03-28 19:36 ` Max Reitz
2017-03-08 19:15 ` [Qemu-devel] [PATCH v2 for-2.10 4/4] block: Add some bdrv_truncate() error messages Max Reitz
2017-03-23 18:03 ` Kevin Wolf
2017-03-28 19:35 ` Max Reitz
2017-03-23 18:05 ` Kevin Wolf [this message]
2017-03-28 19:37 ` [Qemu-devel] [PATCH v2 for-2.10 0/4] block: Add errp to b{lk, drv}_truncate() Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323180523.GF5344@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.