From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: jgross@suse.com, Thomas Huth <thuth@redhat.com>,
sstabellini@kernel.org, Markus Armbruster <armbru@redhat.com>,
Laszlo Ersek <lersek@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>
Subject: [Qemu-devel] [RFC 4/4] q35: Remove fw_cfg* from sysbus whitelist
Date: Thu, 23 Mar 2017 18:28:48 -0300 [thread overview]
Message-ID: <20170323212848.8492-5-ehabkost@redhat.com> (raw)
In-Reply-To: <20170323212848.8492-1-ehabkost@redhat.com>
fw_cfg devices are supposed to be created by the q35 board code,
and not manually using -device. Remove them from the whitelist.
Suggested-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/i386/pc_q35.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 94a3069e16..91d7f67e48 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -307,8 +307,6 @@ static void pc_q35_machine_options(MachineClass *m)
machine_class_add_sysbus_whitelist(m, "amd-iommu");
machine_class_add_sysbus_whitelist(m, "cfi.pflash01");
machine_class_add_sysbus_whitelist(m, "esp");
- machine_class_add_sysbus_whitelist(m, "fw_cfg_io");
- machine_class_add_sysbus_whitelist(m, "fw_cfg_mem");
machine_class_add_sysbus_whitelist(m, "generic-sdhci");
machine_class_add_sysbus_whitelist(m, "hpet");
machine_class_add_sysbus_whitelist(m, "intel-iommu");
--
2.11.0.259.g40922b1
next prev parent reply other threads:[~2017-03-23 21:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 21:28 [Qemu-devel] [RFC 0/4] Replace has_dynamic_sysbus with device type whitelist Eduardo Habkost
2017-03-23 21:28 ` [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class Eduardo Habkost
2017-03-24 8:23 ` Juergen Gross
2017-03-24 10:09 ` Peter Maydell
2017-03-24 10:24 ` Juergen Gross
2017-03-24 11:10 ` Eduardo Habkost
2017-03-24 12:27 ` Juergen Gross
2017-03-24 13:50 ` Eduardo Habkost
2017-03-24 13:59 ` Juergen Gross
2017-03-24 10:32 ` Thomas Huth
2017-03-23 21:28 ` [Qemu-devel] [RFC 2/4] machine: Replace has_dynamic_sysbus with a whitelist Eduardo Habkost
2017-03-23 21:28 ` [Qemu-devel] [RFC 3/4] q35: Remove ioapic devices from sysbus whitelist Eduardo Habkost
2017-03-23 21:28 ` Eduardo Habkost [this message]
2017-03-24 8:27 ` [Qemu-devel] [RFC 0/4] Replace has_dynamic_sysbus with device type whitelist Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323212848.8492-5-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=jgross@suse.com \
--cc=lersek@redhat.com \
--cc=marcel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.