From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [PATCH] net/mlx5: fix TSO header size in case of
	VLAN insertion
Date: Fri, 24 Mar 2017 09:25:32 +0100
Message-ID: <20170324082532.GX12013@autoinstall.dev.6wind.com>
References: <1490272931-145077-1-git-send-email-shahafs@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org
To: Shahaf Shuler <shahafs@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id BBA23D00F
 for <dev@dpdk.org>; Fri, 24 Mar 2017 09:25:41 +0100 (CET)
Received: by mail-wm0-f46.google.com with SMTP id n11so7050356wma.0
 for <dev@dpdk.org>; Fri, 24 Mar 2017 01:25:41 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1490272931-145077-1-git-send-email-shahafs@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Mar 23, 2017 at 02:42:11PM +0200, Shahaf Shuler wrote:
> When VLAN insertion is requested the vlan size must be added to the
> calculation of the TSO header size, as it is not embedded within the
> mbuf l2 length.
> 
> Fixes: 98083fd482a2 ("net/mlx5: add hardware TSO support")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_rxtx.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 823aac8..9e8c6d0 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -548,10 +548,11 @@
>  							buf->ol_flags &
>  							(PKT_TX_TUNNEL_GRE |
>  							 PKT_TX_TUNNEL_VXLAN);
> +				uint8_t vlan_sz = (buf->ol_flags &
> +						  PKT_TX_VLAN_PKT) ? 4 : 0;
>  
> -				tso_header_sz = buf->l2_len + buf->l3_len +
> -						buf->l4_len;
> -
> +				tso_header_sz = buf->l2_len + vlan_sz +
> +						buf->l3_len + buf->l4_len;
>  				if (is_tunneled	&& txq->tunnel_en) {
>  					tso_header_sz += buf->outer_l2_len +
>  							 buf->outer_l3_len;
> -- 
> 1.8.3.1
> 

Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

-- 
Nélio Laranjeiro
6WIND