All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Dave Young <dyoung@redhat.com>, Baoquan He <bhe@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	Thomas Garnier <thgarnie@google.com>,
	Kees Cook <keescook@chromium.org>, Borislav Petkov <bp@alien8.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Bhupesh Sharma <bhsharma@redhat.com>
Subject: Re: [PATCH v2] x86/mm/KASLR: EFI region is mistakenly included into KASLR VA space for randomization
Date: Fri, 24 Mar 2017 11:54:52 +0100	[thread overview]
Message-ID: <20170324105452.GA20282@gmail.com> (raw)
In-Reply-To: <CAKv+Gu-d3M6-T1HbZYjFnPA_KYtdQyCx36fRSXD5vNurjAqXuw@mail.gmail.com>


* Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

> > Turning KASLR off actively degrades that randomization of the kernel virtual 
> > addresses.
> >
> > Am I missing anything?
> >
> 
> No, I think you are right. UEFI runtime services region are likely to consist of 
> R+W+X mappings for the foreseeable future on x86, and the more we tighten down 
> security in other places, the more appealing the UEFI regions become for 
> exploitation (even if they are only mapped while runtime services calls are in 
> progress).

Ok, so I'm fine with the current proposed patch as a temporary workaround, but 
only if we are going to get a real fix as well, ASAP.

Thanks,

	Ingo

  reply	other threads:[~2017-03-24 10:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-24  4:59 [PATCH v2] x86/mm/KASLR: EFI region is mistakenly included into KASLR VA space for randomization Baoquan He
2017-03-24  4:59 ` Baoquan He
     [not found] ` <1490331592-31860-1-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-03-24  8:08   ` Ingo Molnar
2017-03-24  8:08     ` Ingo Molnar
     [not found]     ` <20170324080833.GA15200-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-24  8:34       ` Baoquan He
2017-03-24  8:34         ` Baoquan He
2017-03-24  8:46         ` Dave Young
2017-03-24  8:46           ` Dave Young
2017-03-24  9:24           ` Ingo Molnar
2017-03-24  9:36             ` Borislav Petkov
     [not found]             ` <20170324092433.GA3237-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-24  9:37               ` Ard Biesheuvel
2017-03-24  9:37                 ` Ard Biesheuvel
2017-03-24  9:40                 ` Borislav Petkov
2017-03-24  9:42                   ` Ard Biesheuvel
     [not found]                     ` <CAKv+Gu9cyMccPSjzr9XGT6Gkhq57is+i_VajsZMTbd9eOAMkwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-24  9:46                       ` Borislav Petkov
2017-03-24  9:46                         ` Borislav Petkov
     [not found]                         ` <20170324094656.r2nln4vbidj5jhqt-fF5Pk5pvG8Y@public.gmane.org>
2017-03-24  9:52                           ` Ard Biesheuvel
2017-03-24  9:52                             ` Ard Biesheuvel
     [not found]                 ` <CAKv+Gu_V_VAWuDtKyOY9RS+cdhi+c5z2a7n2kcXVybvvdmPYBw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-24 10:36                   ` Ingo Molnar
2017-03-24 10:36                     ` Ingo Molnar
2017-03-24 10:42                     ` Ard Biesheuvel
2017-03-24 10:54                       ` Ingo Molnar [this message]
2017-03-24 11:52             ` Baoquan He
2017-03-24  8:53     ` Dave Young
2017-03-24  8:10 ` [tip:x86/urgent] x86/mm/KASLR: Exclude EFI region from KASLR VA space randomization tip-bot for Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170324105452.GA20282@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=bhe@redhat.com \
    --cc=bhsharma@redhat.com \
    --cc=bp@alien8.de \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=thgarnie@google.com \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.