All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Thorsten Leemhuis <linux@leemhuis.info>
Cc: ulrik.debie-os@e2big.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled
Date: Fri, 24 Mar 2017 10:00:00 -0700	[thread overview]
Message-ID: <20170324170000.GA18364@dtor-ws> (raw)
In-Reply-To: <8fa42069-fa8c-e59c-f574-8fbabc6ce6d2@leemhuis.info>

Hi Thorsten,

On Fri, Mar 24, 2017 at 11:18:51AM +0100, Thorsten Leemhuis wrote:
> Lo! Dmitry, did this fall through the cracks or is there any reason why
> you didn't yet apply below patch? If the latter: What is needed to get
> things moving? Right now I still have access to the machine for further
> tests, but that will change in a week or two. Ciao, Thorsten

I was waiting for an updated version of the patch with updated info for
E547. The "caps" data is coming from Synaptics caps query, so should be
"50, 12, 09".

Thanks.

> 
> On 10.03.2017 07:53, Thorsten Leemhuis wrote:
> > Lo! ulrik.debie-os@e2big.org wrote on 09.03.2017 18:50:
> >>
> >> Can you also provide the line equivalent for 
> >>  * Fujitsu LIFEBOOK E554   0x570f01        40, 14, 0c      2 hw buttons
> >> ?
> > 
> > Where do I find those three values mentioned in the third column? And is
> > that line important at all? I just did below patch as a drive-by-patch
> > and from looking at the source code I can't immediately spot how to get
> > them :-/
> > 
> > FWIW, it's a 2 hw buttons touchpad and I saw this in dmesg
> > 
> > psmouse serio2: elantech: assuming hardware version 4 (with firmware
> > version )
> > psmouse serio2: elantech: Synaptics capabilities query result 0x50,
> > 0x12, 0x09.
> > psmouse serio2: elantech: Elan sample query result 01, 27, 86
> > 
> > Are those values from "Elan sample query result" what you are looking
> > for? Then the line would be:
> > 
> > Fujitsu LIFEBOOK E547  0x470f00        01, 27, 86      2 hw buttons
> > 
> > Ciao, Thorsten
> > 
> > 
> >> On Thu, Mar 09, 2017 at 09:19:41AM +0100, Thorsten Leemhuis wrote:
> >>>
> >>> Temporary got a Fujitsu Lifebook E547 into my hands and noticed 
> >>> the touchpad only works after running
> >>>
> >>> echo "1" > /sys/devices/platform/i8042/serio2/crc_enabled
> >>>
> >>> Add it to the list of Fujitsu machines that need this workaround.
> >>>
> >>> Cc: stable@vger.kernel.org
> >>> Signed-off-by: Thorsten Leemhuis <linux@leemhuis.info>
> >>> ---
> >>>  drivers/input/mouse/elantech.c | 7 +++++++
> >>>  1 file changed, 7 insertions(+)
> >>>
> >>> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> >>> index efc8ec3..c5e513b 100644
> >>> --- a/drivers/input/mouse/elantech.c
> >>> +++ b/drivers/input/mouse/elantech.c
> >>> @@ -1524,6 +1524,13 @@ static int elantech_reconnect(struct psmouse *psmouse)
> >>>  		},
> >>>  	},
> >>>  	{
> >>> +		/* Fujitsu LIFEBOOK E547  does not work with crc_enabled == 0 */
> >>> +		.matches = {
> >>> +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> >>> +			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E547"),
> >>> +		},
> >>> +	},
> >>> +	{
> >>>  		/* Fujitsu LIFEBOOK E554  does not work with crc_enabled == 0 */
> >>>  		.matches = {
> >>>  			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> >>> -- 
> >>> 1.8.3.1
> >>> --
> >>> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> >>> the body of a message to majordomo@vger.kernel.org
> >>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >>

-- 
Dmitry

  reply	other threads:[~2017-03-24 17:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-09  8:19 [PATCH] Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled Thorsten Leemhuis
2017-03-09 17:50 ` ulrik.debie-os
2017-03-10  6:53   ` Thorsten Leemhuis
2017-03-24 10:18     ` Thorsten Leemhuis
2017-03-24 17:00       ` Dmitry Torokhov [this message]
2017-03-27  8:53         ` [PATCH v2] " Thorsten Leemhuis
2017-04-18 13:42           ` Thorsten Leemhuis
2017-04-18 18:16             ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170324170000.GA18364@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=ulrik.debie-os@e2big.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.