All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers3@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	mtk.manpages@gmail.com,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	xfs <linux-xfs@vger.kernel.org>
Subject: Re: statx manpage
Date: Fri, 24 Mar 2017 13:53:22 -0700	[thread overview]
Message-ID: <20170324205322.GA4986@gmail.com> (raw)
In-Reply-To: <10435.1488907375@warthog.procyon.org.uk>

On Tue, Mar 07, 2017 at 05:22:55PM +0000, David Howells wrote:
> STATX_ALL	[All currently available stuff]
> .TE
> .in
> .PP
> .B "Do not"
> simply set
> .I mask
> to UINT_MAX as one or more bits may, in future, be used to specify an extension
> to the buffer.

To clarify, will an "extension to the buffer" be an increase in the size of
struct statx?  I think it would have to be, otherwise programs filling a struct
statx with STATX_ALL would start breaking as soon as they're rebuilt with the
new value of STATX_ALL, no?  Or would these "extension to the buffer" bits not
be added to STATX_ALL ...?

And I don't suppose there's anything we can do to stop programs from asking for
mask bits that haven't been defined yet, then breaking later if they happen to
be defined as "extensions"?  Maybe adding an extra "buffer size" argument to the
syscall?

I'm concerned that the idea of "extensions" isn't well thought out, and in
practice we'll just be stuck with the current struct size (256 bytes) forever.

- Eric

  parent reply	other threads:[~2017-03-24 20:53 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07  0:06 [PATCH] xfs: report crtime and attribute flags to statx Darrick J. Wong
2017-03-07  5:01 ` Christoph Hellwig
2017-03-07 17:22   ` statx manpage David Howells
2017-03-07 18:02     ` Darrick J. Wong
2017-03-07 18:39       ` David Howells
2017-03-07 18:44         ` Darrick J. Wong
2017-03-07 18:55           ` David Howells
2017-03-07 21:44     ` Andreas Dilger
2017-03-08  9:24       ` David Howells
2017-03-08 15:26         ` Jeff Layton
2017-03-20 16:01           ` Matthew Wilcox
2017-03-22 10:55             ` Jeff Layton
2017-03-07 22:55     ` Eric Biggers
2017-03-08  9:41       ` David Howells
2017-03-10  5:01         ` Eric Biggers
2017-03-08  3:45     ` Eryu Guan
2017-03-09  6:46       ` David Howells
2017-03-09  6:59         ` Eryu Guan
2017-03-09  7:45           ` David Howells
2017-03-09  6:59         ` Darrick J. Wong
2017-03-09 14:01           ` Christoph Hellwig
2017-03-24 20:53     ` Eric Biggers [this message]
2017-03-27  0:46       ` Andreas Dilger
2017-03-27 15:40         ` Darrick J. Wong
2017-03-27 16:25           ` David Howells
2017-03-27 16:46             ` Christoph Hellwig
2017-03-27 18:57               ` David Howells
2017-03-27 19:04               ` Jeff Layton
2017-03-28 19:39                 ` Andreas Dilger
2017-03-28 20:22                   ` Jeff Layton
2017-03-31 15:49                 ` Christoph Hellwig
2017-03-28  0:13               ` [PATCH] Add initial batch of statx() LTP tests David Howells
2017-03-28  6:28                 ` Christoph Hellwig
2017-03-28  8:23                   ` David Howells
2017-03-27  9:55       ` statx manpage David Howells
2017-03-31 15:56     ` Christoph Hellwig
     [not found]     ` <20170331155653.GA27655-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-03-31 16:43       ` David Howells
2017-03-31 16:43         ` David Howells
2017-03-07 17:23   ` [PATCH] xfs: report crtime and attribute flags to statx Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170324205322.GA4986@gmail.com \
    --to=ebiggers3@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=dhowells@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.