From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralph Sennhauser Subject: Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Date: Fri, 24 Mar 2017 23:23:40 +0100 Message-ID: <20170324232340.7487f638@gmail.com> References: <20170324141815.7252-1-ralph.sennhauser@gmail.com> <20170324141815.7252-5-ralph.sennhauser@gmail.com> <20170324143505.GK28518@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170324143505.GK28518-g2DYL2Zd6BY@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Lunn Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Imre Kaloz , Thierry Reding , Linus Walleij , Alexandre Courbot , Rob Herring , Mark Rutland , Jason Cooper , Gregory Clement , Sebastian Hesselbarth , Russell King , linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-gpio@vger.kernel.org On Fri, 24 Mar 2017 15:35:05 +0100 Andrew Lunn wrote: > > + pwm_fan { > > /* SUNON HA4010V4-0000-C99 */ > > - compatible = "gpio-fan"; > > - gpios = <&gpio0 24 0>; > > > > - gpio-fan,speed-map = <0 0 > > - 4500 1>; > > + compatible = "pwm-fan"; > > + pwms = <&gpio0 24 4000 0>; > > Hi Ralph > > I believe this last 0 is the flags parameter. Now that we have > #pwm-cells = 1, i think this last 0 should be dropped. > > Andrew Missed it. Duly noted like the other comments. Thanks Ralph -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: ralph.sennhauser@gmail.com (Ralph Sennhauser) Date: Fri, 24 Mar 2017 23:23:40 +0100 Subject: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan In-Reply-To: <20170324143505.GK28518@lunn.ch> References: <20170324141815.7252-1-ralph.sennhauser@gmail.com> <20170324141815.7252-5-ralph.sennhauser@gmail.com> <20170324143505.GK28518@lunn.ch> Message-ID: <20170324232340.7487f638@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 24 Mar 2017 15:35:05 +0100 Andrew Lunn wrote: > > + pwm_fan { > > /* SUNON HA4010V4-0000-C99 */ > > - compatible = "gpio-fan"; > > - gpios = <&gpio0 24 0>; > > > > - gpio-fan,speed-map = <0 0 > > - 4500 1>; > > + compatible = "pwm-fan"; > > + pwms = <&gpio0 24 4000 0>; > > Hi Ralph > > I believe this last 0 is the flags parameter. Now that we have > #pwm-cells = 1, i think this last 0 should be dropped. > > Andrew Missed it. Duly noted like the other comments. Thanks Ralph From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966199AbdCXWX6 (ORCPT ); Fri, 24 Mar 2017 18:23:58 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33095 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964917AbdCXWXu (ORCPT ); Fri, 24 Mar 2017 18:23:50 -0400 Date: Fri, 24 Mar 2017 23:23:40 +0100 From: Ralph Sennhauser To: Andrew Lunn Cc: linux-gpio@vger.kernel.org, Imre Kaloz , Thierry Reding , Linus Walleij , Alexandre Courbot , Rob Herring , Mark Rutland , Jason Cooper , Gregory Clement , Sebastian Hesselbarth , Russell King , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Message-ID: <20170324232340.7487f638@gmail.com> In-Reply-To: <20170324143505.GK28518@lunn.ch> References: <20170324141815.7252-1-ralph.sennhauser@gmail.com> <20170324141815.7252-5-ralph.sennhauser@gmail.com> <20170324143505.GK28518@lunn.ch> Organization: none X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Mar 2017 15:35:05 +0100 Andrew Lunn wrote: > > + pwm_fan { > > /* SUNON HA4010V4-0000-C99 */ > > - compatible = "gpio-fan"; > > - gpios = <&gpio0 24 0>; > > > > - gpio-fan,speed-map = <0 0 > > - 4500 1>; > > + compatible = "pwm-fan"; > > + pwms = <&gpio0 24 4000 0>; > > Hi Ralph > > I believe this last 0 is the flags parameter. Now that we have > #pwm-cells = 1, i think this last 0 should be dropped. > > Andrew Missed it. Duly noted like the other comments. Thanks Ralph