From: Solar Designer <solar@openwall.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Andrey Konovalov <andreyknvl@google.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net] ping: implement proper locking
Date: Sat, 25 Mar 2017 01:30:29 +0100 [thread overview]
Message-ID: <20170325003028.GA31430@openwall.com> (raw)
In-Reply-To: <1490398185.24891.5.camel@edumazet-glaptop3.roam.corp.google.com>
On Fri, Mar 24, 2017 at 04:29:45PM -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> We got a report of yet another bug in ping
>
> http://www.openwall.com/lists/oss-security/2017/03/24/6
>
> ->disconnect() is not called with socket lock held.
>
> Fix this by acquiring ping rwlock earlier.
>
> Thanks to Alexander and Andrey for letting us know of this problem.
>
> Fixes: c319b4d76b9e ("net: ipv4: add IPPROTO_ICMP socket kind")
> Reported-by: Solar Designer <solar@openwall.com>
> Reported-by: Andrey Konovalov <andreyknvl@google.com>
We should credit the original reporter, who most likely found this by
fuzzing. It's danieljiang0415 on GitHub and Twitter. Unfortunately, I
don't know their e-mail address. I'll try asking.
Alexander
next prev parent reply other threads:[~2017-03-25 0:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 23:29 [PATCH net] ping: implement proper locking Eric Dumazet
2017-03-25 0:30 ` Solar Designer [this message]
2017-03-25 2:10 ` David Miller
2017-03-25 2:33 ` Eric Dumazet
2017-03-25 2:36 ` [PATCH v2 " Eric Dumazet
2017-03-25 3:51 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2017-03-25 0:44 [PATCH " Xose Vazquez Perez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170325003028.GA31430@openwall.com \
--to=solar@openwall.com \
--cc=andreyknvl@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.