From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH V2 rdma-core 6/6] Bump version and update debian
Date: Sun, 26 Mar 2017 14:45:23 -0600 [thread overview]
Message-ID: <20170326204523.GC3113@obsidianresearch.com> (raw)
In-Reply-To: <20170325071326.GF20443-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Sat, Mar 25, 2017 at 10:13:26AM +0300, Leon Romanovsky wrote:
> > Do you need a changelog entry to have stuff in the symbols file?
>
> I think that we need corresponding version in changelog.
There are lots of counter examples..
libibverbs.so.1 libibverbs1 #MINVER#
IBVERBS_1.0@IBVERBS_1.0 1.1.6
IBVERBS_1.1@IBVERBS_1.1 1.1.6
Eg we do not have 1.1.6 in the changelog
> > BTW, there are bad looking things in travis with this PR:
> >
> > parsechangelog/debian: warning: debian/changelog(l5): found start of entry where expected more change data or trailer
> > LINE: rdma-core (13-1) unstable; urgency=low
> > parsechangelog/debian: warning: debian/changelog(l5): found eof
> > where expected more change data or trailer
> >
> > libmlx5.so.1 ibverbs-providers #MINVER#
> > MLX5_1.0@MLX5_1.0 13-1
> > MLX5_1.14@MLX5_1.14 14-1
> > + MLX5_1.1@MLX5_1.1 14-1
> > + mlx5dv_create_cq@MLX5_1.1 14-1
> >
> > Etc..
>
> It is actual error, strange that travis passed while it was supposed to fail.
Maybe we should run dpkg-shlibdeps manually and somehow fail if this
situation happens... Can you look at that?
> The commit
> https://github.com/linux-rdma/rdma-core/pull/103/commits/4ba27e66294f59db7c969bde1580e7aa8d718cd7
> added MLX5_1.1, but in commit
> https://github.com/linux-rdma/rdma-core/pull/103/commits/9614ecdae2a6a5448cab819a057c703a570b3686
> debian was updated with incorrect stanza (MLX5_1.14).
Yes, we went back and forth on this unfortunately, I gave some bad
advice.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-03-26 20:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 13:55 [PATCH V2 rdma-core 0/6] Enable mlx5 vendor functionality Yishai Hadas
[not found] ` <1490277329-8738-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-03-23 13:55 ` [PATCH V2 rdma-core 1/6] mlx5: Explicitly align mlx5 query device response to 64 bit Yishai Hadas
2017-03-23 13:55 ` [PATCH V2 rdma-core 2/6] mlx5: Report multi packet send WQE capability for mlx5 based hardware Yishai Hadas
2017-03-23 13:55 ` [PATCH V2 rdma-core 3/6] mlx5: Report CQE compression capabilities through mlx5 direct verbs Yishai Hadas
2017-03-23 13:55 ` [PATCH V2 rdma-core 4/6] verbs: Expose verbs init CQ helper API Yishai Hadas
2017-03-23 13:55 ` [PATCH V2 rdma-core 5/6] mlx5: Expose direct create_cq with private data Yishai Hadas
2017-03-23 13:55 ` [PATCH V2 rdma-core 6/6] Bump version and update debian Yishai Hadas
[not found] ` <1490277329-8738-7-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-03-23 17:19 ` Jason Gunthorpe
[not found] ` <20170323171916.GB5840-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-03-23 19:11 ` Leon Romanovsky
[not found] ` <20170323191155.GC20443-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-03-23 20:02 ` Jason Gunthorpe
[not found] ` <20170323200214.GA10344-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-03-24 13:49 ` Leon Romanovsky
[not found] ` <20170324134905.GE20443-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-03-24 18:09 ` Jason Gunthorpe
[not found] ` <20170324180914.GA13059-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-03-25 7:13 ` Leon Romanovsky
[not found] ` <20170325071326.GF20443-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-03-25 7:19 ` Leon Romanovsky
2017-03-26 20:45 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170326204523.GC3113@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.