From: Okash Khawaja <okash.khawaja@gmail.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
gregkh@linuxfoundation.org, w.d.hubbs@gmail.com,
chris@the-brannons.com, kirk@reisers.ca, rvarsha016@gmail.com,
arushisinghal19971997@gmail.com, shiva@exdev.nl,
speakup@linux-speakup.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: speakup: fix warning for static declaration
Date: Mon, 27 Mar 2017 09:39:37 +0100 [thread overview]
Message-ID: <20170327083937.GA21938@sanghar> (raw)
In-Reply-To: <20170327075853.tmldwny6ih2f4vno@var.youpi.perso.aquilenet.fr>
On Mon, Mar 27, 2017 at 09:58:53AM +0200, Samuel Thibault wrote:
> Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote:
> > Thanks for this :) Could you also move the function higher in the same
> > file - above line 139 where all static functions are defined?
>
> I'd say no need for this. spk_serial_in is just above. Moving functions
> just for the sake of static vs non-static does not make the code more
> readable to my eyes :)
> (and it makes tracking changes harder in git annotate)
>
> Samuel
Fair enough. When I marked it as static and moved it higher, I
misinterpreted your comment as we neither want it static nor moved. You
probably meant the latter :)
next prev parent reply other threads:[~2017-03-27 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 6:37 [PATCH] staging: speakup: fix warning for static declaration Gustavo A. R. Silva
2017-03-27 7:51 ` Okash Khawaja
2017-03-27 7:58 ` Samuel Thibault
2017-03-27 8:39 ` Okash Khawaja [this message]
2017-03-27 7:55 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327083937.GA21938@sanghar \
--to=okash.khawaja@gmail.com \
--cc=arushisinghal19971997@gmail.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=garsilva@embeddedor.com \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=rvarsha016@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=shiva@exdev.nl \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.