All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Yanjun Zhu <yanjun.zhu@oracle.com>
Cc: santosh.shilimkar@oracle.com, netdev@vger.kernel.org,
	linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
	junxiao.bi@oracle.com, joe.jin@oracle.com
Subject: Re: [PATCH 1/5] rds: tcp: release the created connection
Date: Mon, 27 Mar 2017 05:17:29 -0400	[thread overview]
Message-ID: <20170327091729.GA30457@oracle.com> (raw)
In-Reply-To: <58D8C7D9.1070509@oracle.com>

On (03/27/17 16:05), Yanjun Zhu wrote:
> Sorry. I just made simple test. It seems that it worked well. Would you like
> to show me some test about this patch?
> 

Your patch is a non-trivial bug. Dont do this.

Please read the comments above the "goto rst_nsk" in that function.
Also note the comments above rds_conn_destroy.

Thanks
--Sowmini

  reply	other threads:[~2017-03-27  9:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27  7:06 [PATCH 0/5] rds: trivial patches Zhu Yanjun
2017-03-27  7:06 ` [PATCH 2/5] rds: rdma: fix memory leak error Zhu Yanjun
2017-03-27  7:06 ` [PATCH 4/5] rds: remove the unused variable Zhu Yanjun
     [not found] ` <1490598390-13812-1-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-03-27  7:06   ` [PATCH 1/5] rds: tcp: release the created connection Zhu Yanjun
2017-03-27  7:37     ` Sowmini Varadhan
     [not found]       ` <20170327073756.GA21982-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-03-27  8:05         ` Yanjun Zhu
2017-03-27  9:17           ` Sowmini Varadhan [this message]
2017-03-27  7:06   ` [PATCH 3/5] rds: remove unnecessary returned value check Zhu Yanjun
2017-03-27  7:06   ` [PATCH 5/5] rds: ib: add the static type to the functions Zhu Yanjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170327091729.GA30457@oracle.com \
    --to=sowmini.varadhan@oracle.com \
    --cc=joe.jin@oracle.com \
    --cc=junxiao.bi@oracle.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rds-devel@oss.oracle.com \
    --cc=santosh.shilimkar@oracle.com \
    --cc=yanjun.zhu@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.