From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: David Howells <dhowells@redhat.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
Andreas Dilger <adilger@dilger.ca>,
Christoph Hellwig <hch@infradead.org>,
fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 0/2 V2] xfs_io: hook up statx
Date: Tue, 28 Mar 2017 08:58:22 +1100 [thread overview]
Message-ID: <20170327215822.GH17542@dastard> (raw)
In-Reply-To: <07e3308b-11a8-90d4-4ac9-96c3c36d3c4a@sandeen.net>
On Mon, Mar 27, 2017 at 12:47:33PM -0500, Eric Sandeen wrote:
> On 3/27/17 5:00 AM, David Howells wrote:
> > Eric Sandeen <sandeen@sandeen.net> wrote:
> >
> >> These 2 patches are a second pass to add a statx command
> >> to xfs_io in hopes that it will aid creation of xfstests
> >> statx regression tests.
> >
> > Would it be possible to redirect all the stat() calls made by xfstests to
> > statx() with translation of the output buffer back to struct stat?
>
> I'm sure LD_PRELOAD tricks could do that, but it'd be a little unusual
> for xfstests, at least - kind of a side hack that's not really expected
> and therefore wouldn't get consistently run.
>
> Honestly, just write a bash script for xfstests which tests expected
> statx behavior for various inputs, verifies what it can against stat,
> and it's all good...
Don't forget to add it to fsstress and randomise the flag values it
uses...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-03-27 21:58 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 4:32 [PATCH 0/2 V2] xfs_io: hook up statx Eric Sandeen
2017-03-24 4:34 ` [PATCH 1/2 V2] xfs_io: move stat functions to new file Eric Sandeen
2017-03-24 4:34 ` Eric Sandeen
2017-03-27 15:52 ` Darrick J. Wong
2017-03-27 20:26 ` David Howells
2017-03-27 20:32 ` Darrick J. Wong
2017-03-24 4:45 ` [PATCH 2/2 V2] xfs_io: hook up statx Eric Sandeen
2017-03-27 15:54 ` Darrick J. Wong
2017-03-27 20:20 ` David Howells
2017-03-27 20:58 ` Eric Biggers
2017-03-28 21:57 ` Eric Sandeen
2017-03-28 10:22 ` [PATCH] xfs_io: changes to statx interface David Howells
2017-03-28 10:51 ` Amir Goldstein
2017-03-28 12:31 ` David Howells
2017-03-28 13:34 ` Amir Goldstein
2017-03-28 14:04 ` David Howells
2017-03-28 18:01 ` Amir Goldstein
2017-03-28 14:38 ` [PATCH] xfs_io: changes to statx interface [ver #2] David Howells
2017-03-28 14:41 ` David Howells
2017-03-28 14:41 ` David Howells
2017-03-28 16:42 ` Eric Sandeen
2017-03-28 17:35 ` Amir Goldstein
2017-03-28 17:56 ` David Howells
2017-03-28 18:11 ` Amir Goldstein
2017-03-28 20:36 ` Eric Sandeen
2017-03-28 18:40 ` Andreas Dilger
2017-03-28 19:07 ` Amir Goldstein
2017-03-28 22:12 ` Eric Sandeen
2017-03-28 23:18 ` Dave Chinner
2017-03-29 15:24 ` David Howells
2017-03-29 15:49 ` [PATCH] xfs_io: changes to statx interface [ver #3] David Howells
2017-03-29 16:40 ` David Howells
2017-03-29 21:32 ` Eric Sandeen
2017-03-29 21:55 ` [PATCH] xfs_io: changes to statx interface [ver #4] David Howells
2017-03-27 10:00 ` [PATCH 0/2 V2] xfs_io: hook up statx David Howells
2017-03-27 17:47 ` Eric Sandeen
2017-03-27 18:05 ` Eric Sandeen
2017-03-27 21:58 ` Dave Chinner [this message]
2017-03-28 7:30 ` Amir Goldstein
2017-03-28 9:39 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327215822.GH17542@dastard \
--to=david@fromorbit.com \
--cc=adilger@dilger.ca \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.