From: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>
To: Jim Qu <Jim.Qu-5C7GfCeVMHo@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amd/amdgpu: fix Tonga S3 resume hang on rhel6.8
Date: Tue, 28 Mar 2017 18:27:53 +0800 [thread overview]
Message-ID: <20170328102752.GA940@hr-amur2> (raw)
In-Reply-To: <1490693274-11017-1-git-send-email-Jim.Qu-5C7GfCeVMHo@public.gmane.org>
On Tue, Mar 28, 2017 at 05:27:54PM +0800, Jim Qu wrote:
> 1. security firmware loading has moved to sw init, so this code
> is useless.
> 2. it seems that driver could not call request_firmware on
> kernel 2.6, when S3 resume. for request firmware depends on
> userspace, at this time, userspace is freeze.
>
> Change-Id: I13977c60314ffe976924b1fdad1ab10df5d93c82
> Signed-off-by: Jim Qu <Jim.Qu@amd.com>
Yes, since smu_init is moved to sw_init, we won't meet to request firmware
two times yet.
Acked-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> index d6cbdbe..a1a2d44 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> @@ -840,9 +840,6 @@ static int amdgpu_cgs_get_firmware_info(struct cgs_device *cgs_device,
> const struct common_firmware_header *header;
> struct amdgpu_firmware_info *ucode = NULL;
>
> - if (CGS_UCODE_ID_SMU_SK == type)
> - amdgpu_cgs_rel_firmware(cgs_device, CGS_UCODE_ID_SMU);
> -
> if (!adev->pm.fw) {
> switch (adev->asic_type) {
> case CHIP_TOPAZ:
> --
> 1.9.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-03-28 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 9:27 [PATCH] drm/amd/amdgpu: fix Tonga S3 resume hang on rhel6.8 Jim Qu
[not found] ` <1490693274-11017-1-git-send-email-Jim.Qu-5C7GfCeVMHo@public.gmane.org>
2017-03-28 10:27 ` Huang Rui [this message]
2017-03-29 1:56 ` Zhang, Jerry (Junwei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328102752.GA940@hr-amur2 \
--to=ray.huang-5c7gfcevmho@public.gmane.org \
--cc=Jim.Qu-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.