From: David Sterba <dsterba@suse.cz>
To: slyich@gmail.com
Cc: Sergei Trofimovich <slyfox@gentoo.org>,
linux-btrfs@vger.kernel.org, Mike Gilbert <floppym@gentoo.org>
Subject: Re: [PATCH] btrfs-progs: fix missing __error symbol in libbtrfs.so.0
Date: Tue, 28 Mar 2017 13:26:43 +0200 [thread overview]
Message-ID: <20170328112643.GV4781@suse.cz> (raw)
In-Reply-To: <20170327210720.10775-1-slyich@gmail.com>
On Mon, Mar 27, 2017 at 10:07:20PM +0100, slyich@gmail.com wrote:
> From: Sergei Trofimovich <slyfox@gentoo.org>
>
> The easiest way to reproduce the error is to try to build
> btrfs-progs with
> $ make LDFLAGS=-Wl,--no-undefined
>
> btrfs-list.o: In function `lookup_ino_path':
> btrfs-list.c:(.text+0x7d2): undefined reference to `__error'
>
> Noticed by Denis Descheneaux when snapper tool
> stopped working after upgrade to btrfs-progs-4.10.
>
> As soname didn't change in 4.9 -> 4.10 release
> I assume it's just an object file omission
> in library depends and not the API/ABI change
> of the library error printing.
>
> Cc: linux-btrfs@vger.kernel.org
> Cc: Mike Gilbert <floppym@gentoo.org>
> Reported-by: Denis Descheneaux
> Bug: https://bugs.gentoo.org/show_bug.cgi?id=613890
>
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
I've replaced my patch with yours, thanks.
prev parent reply other threads:[~2017-03-28 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-26 20:37 Missing __error symbol in btrfs-progs-4.10 Mike Gilbert
2017-03-27 11:47 ` David Sterba
2017-03-27 21:07 ` [PATCH] btrfs-progs: fix missing __error symbol in libbtrfs.so.0 slyich
2017-03-28 11:26 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328112643.GV4781@suse.cz \
--to=dsterba@suse.cz \
--cc=floppym@gentoo.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=slyfox@gentoo.org \
--cc=slyich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.