From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Gargi Sharma <gs051095@gmail.com>
Cc: netfilter-devel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 0/3] ebtables: Constify option struct
Date: Tue, 28 Mar 2017 14:22:51 +0200 [thread overview]
Message-ID: <20170328122251.GA1100@salvia> (raw)
In-Reply-To: <cover.1490699407.git.gs051095@gmail.com>
On Tue, Mar 28, 2017 at 04:57:48PM +0530, Gargi Sharma wrote:
> The struct option is generally used only to initialise
> fields inside certain structs and is not modified anywhere.
> Done using Coccinelle:
>
> @r1 disable optional_qualifier@
> identifier s,i;
> position p;
> @@
>
> static struct option i@p[] ={...};
>
> @ok1@
> identifier r1.i;
> expression e;
> position p;
> @@
> e = i@p
>
> @bad@
> position p != {r1.p,ok1.p};
> identifier r1.i;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> static
> +const
> struct option i[] = { ... };
>
> Gargi Sharma (3):
> ebtables: extensions: Constify option struct
> ebtables: extensions: Constify option struct
> ebtables: extensions: Constify option struct
Please, collapse this patches in one single.
They are part of the same logical update and...
> extensions/ebt_802_3.c | 2 +-
> extensions/ebt_among.c | 2 +-
> extensions/ebt_arp.c | 2 +-
> extensions/ebt_arpreply.c | 2 +-
> extensions/ebt_inat.c | 4 ++--
> extensions/ebt_ip.c | 2 +-
> extensions/ebt_limit.c | 2 +-
> extensions/ebt_log.c | 2 +-
> extensions/ebt_mark.c | 2 +-
> extensions/ebt_mark_m.c | 2 +-
> extensions/ebt_nat.c | 4 ++--
> extensions/ebt_nflog.c | 2 +-
> extensions/ebt_pkttype.c | 2 +-
> extensions/ebt_redirect.c | 2 +-
> extensions/ebt_standard.c | 2 +-
> extensions/ebt_stp.c | 2 +-
> extensions/ebt_ulog.c | 2 +-
> extensions/ebt_vlan.c | 2 +-
> 18 files changed, 20 insertions(+), 20 deletions(-)
diffstat shows this update is rather small.
prev parent reply other threads:[~2017-03-28 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 11:27 [PATCH 0/3] ebtables: Constify option struct Gargi Sharma
2017-03-28 11:27 ` [PATCH 1/3] ebtables: extensions: " Gargi Sharma
2017-03-28 11:27 ` [PATCH 2/3] " Gargi Sharma
2017-03-28 11:27 ` [PATCH 3/3] " Gargi Sharma
2017-03-28 12:22 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328122251.GA1100@salvia \
--to=pablo@netfilter.org \
--cc=gs051095@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.