From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH] drm/vmwgfx: Remove getparam error message Date: Tue, 28 Mar 2017 10:15:07 -0300 Message-ID: <20170328131507.GC2311@joana> References: <1490690686-4235-1-git-send-email-thellstrom@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt0-f193.google.com (mail-qt0-f193.google.com [209.85.216.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9057A6E5B8 for ; Tue, 28 Mar 2017 13:15:14 +0000 (UTC) Received: by mail-qt0-f193.google.com with SMTP id n37so11975650qtb.3 for ; Tue, 28 Mar 2017 06:15:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1490690686-4235-1-git-send-email-thellstrom@vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Hellstrom Cc: stable@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVGhvbWFzLAoKMjAxNy0wMy0yOCBUaG9tYXMgSGVsbHN0cm9tIDx0aGVsbHN0cm9tQHZtd2Fy ZS5jb20+OgoKPiBUaGUgbWVzYSB3aW5zeXMgc29tZXRpbWVzIHVzZXMgdW5pbXBsZW1lbnRlZCBw YXJhbWV0ZXIgcmVxdWVzdHMgdG8KPiBjaGVjayBmb3IgZmVhdHVyZXMuIFJlbW92ZSB0aGUgZXJy b3IgbWVzc2FnZSB0byBhdm9pZCBibG9hdGluZyB0aGUKPiBrZXJuZWwgbG9nLgo+IAo+IENjOiA8 c3RhYmxlQHZnZXIua2VybmVsLm9yZz4KPiBTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgSGVsbHN0cm9t IDx0aGVsbHN0cm9tQHZtd2FyZS5jb20+Cj4gUmV2aWV3ZWQtYnk6IEJyaWFuIFBhdWwgPGJyaWFu cEB2bXdhcmUuY29tPgo+IFJldmlld2VkLWJ5OiBTaW5jbGFpciBZZWggPHN5ZWhAdm13YXJlLmNv bT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfaW9jdGwuYyB8IDIgLS0K PiAgMSBmaWxlIGNoYW5nZWQsIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2lvY3RsLmMgYi9kcml2ZXJzL2dwdS9kcm0vdm13Z2Z4 L3Ztd2dmeF9pb2N0bC5jCj4gaW5kZXggMTgwMmQwZS4uNWVjMjRmZCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9pb2N0bC5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL3Ztd2dmeC92bXdnZnhfaW9jdGwuYwo+IEBAIC0xMTQsOCArMTE0LDYgQEAgaW50IHZtd19n ZXRwYXJhbV9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAJCXBh cmFtLT52YWx1ZSA9IGRldl9wcml2LT5oYXNfZHg7Cj4gIAkJYnJlYWs7Cj4gIAlkZWZhdWx0Ogo+ IC0JCURSTV9FUlJPUigiSWxsZWdhbCB2bXdnZnggZ2V0IHBhcmFtIHJlcXVlc3Q6ICVkXG4iLAo+ IC0JCQkgIHBhcmFtLT5wYXJhbSk7CgpIb3cgYWJvdXQgdHVybmluZyBpdCBpbnRvIGEgZGVidWcg bWVzc2FnZSBpbnN0ZWFkPyBEbyB5b3UgdGhpbmsgaXQgd2lsbApiZSB1c2VmdWw/CgpHdXN0YXZv Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f193.google.com ([209.85.216.193]:33026 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754047AbdC1NPZ (ORCPT ); Tue, 28 Mar 2017 09:15:25 -0400 Received: by mail-qt0-f193.google.com with SMTP id r45so11975373qte.0 for ; Tue, 28 Mar 2017 06:15:19 -0700 (PDT) Date: Tue, 28 Mar 2017 10:15:07 -0300 From: Gustavo Padovan To: Thomas Hellstrom Cc: dri-devel@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [PATCH] drm/vmwgfx: Remove getparam error message Message-ID: <20170328131507.GC2311@joana> References: <1490690686-4235-1-git-send-email-thellstrom@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490690686-4235-1-git-send-email-thellstrom@vmware.com> Sender: stable-owner@vger.kernel.org List-ID: Hi Thomas, 2017-03-28 Thomas Hellstrom : > The mesa winsys sometimes uses unimplemented parameter requests to > check for features. Remove the error message to avoid bloating the > kernel log. > > Cc: > Signed-off-by: Thomas Hellstrom > Reviewed-by: Brian Paul > Reviewed-by: Sinclair Yeh > --- > drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c > index 1802d0e..5ec24fd 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c > @@ -114,8 +114,6 @@ int vmw_getparam_ioctl(struct drm_device *dev, void *data, > param->value = dev_priv->has_dx; > break; > default: > - DRM_ERROR("Illegal vmwgfx get param request: %d\n", > - param->param); How about turning it into a debug message instead? Do you think it will be useful? Gustavo