From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v3] tpm: Apply a sane minimum adapterlimit value for retransmission. Date: Tue, 28 Mar 2017 18:20:44 +0200 Message-ID: <20170328162044.GA29742@lunn.ch> References: <20170328152938.14539-1-enric.balletbo@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170328152938.14539-1-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Enric Balletbo i Serra Cc: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bryan Freed , tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Mar 28, 2017 at 05:29:38PM +0200, Enric Balletbo i Serra wrote: > From: Bryan Freed > > When the I2C Infineon part is attached to an I2C adapter that imposes > a size limitation, large requests will fail with -EOPNOTSUPP. Retry > them with a sane minimum size without re-issuing the 0x05 command > as this appears to occasionally put the TPM in a bad state. > > Signed-off-by: Bryan Freed > [rework the patch to adapt to the feedback received] > Signed-off-by: Enric Balletbo i Serra This looks O.K. now. Thanks for remembering the adaptor limit. Acked-by: Andrew Lunn Andrew ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755443AbdC1QUv (ORCPT ); Tue, 28 Mar 2017 12:20:51 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:38029 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753384AbdC1QUr (ORCPT ); Tue, 28 Mar 2017 12:20:47 -0400 Date: Tue, 28 Mar 2017 18:20:44 +0200 From: Andrew Lunn To: Enric Balletbo i Serra Cc: Peter Huewe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, wsa@the-dreams.de, Jarkko Sakkinen , Bryan Freed Subject: Re: [PATCH v3] tpm: Apply a sane minimum adapterlimit value for retransmission. Message-ID: <20170328162044.GA29742@lunn.ch> References: <20170328152938.14539-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170328152938.14539-1-enric.balletbo@collabora.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 28, 2017 at 05:29:38PM +0200, Enric Balletbo i Serra wrote: > From: Bryan Freed > > When the I2C Infineon part is attached to an I2C adapter that imposes > a size limitation, large requests will fail with -EOPNOTSUPP. Retry > them with a sane minimum size without re-issuing the 0x05 command > as this appears to occasionally put the TPM in a bad state. > > Signed-off-by: Bryan Freed > [rework the patch to adapt to the feedback received] > Signed-off-by: Enric Balletbo i Serra This looks O.K. now. Thanks for remembering the adaptor limit. Acked-by: Andrew Lunn Andrew