From: git@jeffhostetler.com
To: git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: [PATCH v3 2/2] test-core-checksum-index: core.checksumindex test helper
Date: Tue, 28 Mar 2017 19:07:32 +0000 [thread overview]
Message-ID: <20170328190732.59486-3-git@jeffhostetler.com> (raw)
In-Reply-To: <20170328190732.59486-1-git@jeffhostetler.com>
From: Jeff Hostetler <jeffhost@microsoft.com>
Created test helper to measure read_index() with and without
core.checksumindex set and report performance.
Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
---
Makefile | 1 +
t/helper/.gitignore | 1 +
t/helper/test-core-checksum-index.c | 77 +++++++++++++++++++++++++++++++++++++
3 files changed, 79 insertions(+)
create mode 100644 t/helper/test-core-checksum-index.c
diff --git a/Makefile b/Makefile
index 9ec6065..6049427 100644
--- a/Makefile
+++ b/Makefile
@@ -607,6 +607,7 @@ PROGRAMS += $(patsubst %.o,git-%$X,$(PROGRAM_OBJS))
TEST_PROGRAMS_NEED_X += test-chmtime
TEST_PROGRAMS_NEED_X += test-ctype
TEST_PROGRAMS_NEED_X += test-config
+TEST_PROGRAMS_NEED_X += test-core-checksum-index
TEST_PROGRAMS_NEED_X += test-date
TEST_PROGRAMS_NEED_X += test-delta
TEST_PROGRAMS_NEED_X += test-dump-cache-tree
diff --git a/t/helper/.gitignore b/t/helper/.gitignore
index d6e8b36..f651a6b 100644
--- a/t/helper/.gitignore
+++ b/t/helper/.gitignore
@@ -1,6 +1,7 @@
/test-chmtime
/test-ctype
/test-config
+/test-core-checksum-index
/test-date
/test-delta
/test-dump-cache-tree
diff --git a/t/helper/test-core-checksum-index.c b/t/helper/test-core-checksum-index.c
new file mode 100644
index 0000000..0452dc2
--- /dev/null
+++ b/t/helper/test-core-checksum-index.c
@@ -0,0 +1,77 @@
+#include "cache.h"
+#include "parse-options.h"
+
+uint64_t time_runs(int do_checksum, int count)
+{
+ uint64_t t0, t1;
+ uint64_t sum = 0;
+ uint64_t avg;
+ int i;
+
+ git_config_set_gently("core.checksumindex",
+ (do_checksum ? "true" : "false"));
+
+ for (i = 0; i < count; i++) {
+ t0 = getnanotime();
+ read_cache();
+ t1 = getnanotime();
+
+ sum += (t1 - t0);
+
+ printf("%f %d [cache_nr %d]\n",
+ ((double)(t1 - t0))/1000000000,
+ do_checksum,
+ the_index.cache_nr);
+ fflush(stdout);
+
+ discard_cache();
+ }
+
+ avg = sum / count;
+ if (count > 1) {
+ printf("%f %d avg\n",
+ (double)avg/1000000000,
+ do_checksum);
+ fflush(stdout);
+ }
+
+ return avg;
+}
+
+int cmd_main(int argc, const char **argv)
+{
+ int original_do_checksum;
+ int count = 1;
+ const char *usage[] = {
+ "test-core-checksum-index",
+ NULL
+ };
+ struct option options[] = {
+ OPT_INTEGER('c', "count", &count, "number of passes"),
+ OPT_END(),
+ };
+ const char *prefix;
+ uint64_t avg_0, avg_1;
+
+ prefix = setup_git_directory();
+ argc = parse_options(argc, argv, prefix, options, usage, 0);
+
+ if (count < 1)
+ die("count must greater than zero");
+
+ /* throw away call to get the index in the disk cache */
+ read_cache();
+ discard_cache();
+
+ git_config_get_bool("core.checksumindex", &original_do_checksum);
+
+ avg_1 = time_runs(1, count);
+ avg_0 = time_runs(0, count);
+
+ git_config_set_gently("core.checksumindex",
+ ((original_do_checksum) ? "true" : "false"));
+
+ if (avg_0 >= avg_1)
+ die("skipping index checksum verification did not help");
+ return 0;
+}
--
2.9.3
next prev parent reply other threads:[~2017-03-28 19:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 19:07 [PATCH v3 0/2] read-cache: call verify_hdr() in a background thread git
2017-03-28 19:07 ` [PATCH v3 1/2] read-cache: core.checksumindex git
2017-03-28 19:07 ` git [this message]
2017-03-28 19:16 ` [PATCH v3 0/2] read-cache: call verify_hdr() in a background thread Jeff King
2017-03-28 19:50 ` Jeff Hostetler
2017-03-28 19:56 ` Jeff King
2017-03-30 19:49 ` Junio C Hamano
2017-03-30 19:58 ` Jeff King
2017-03-30 20:44 ` Junio C Hamano
2017-03-31 13:20 ` Jeff Hostetler
2017-03-30 20:06 ` Thomas Gummerer
2017-03-30 20:39 ` Jeff King
2017-03-31 13:23 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328190732.59486-3-git@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.