From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: [Qemu-devel] [PATCH v3 for-2.10 0/4] block: Add errp to b{lk, drv}_truncate()
Date: Tue, 28 Mar 2017 22:51:25 +0200 [thread overview]
Message-ID: <20170328205129.15138-1-mreitz@redhat.com> (raw)
Having an Error parameter for these functions makes sense because we
sometimes want a bit more information than just "Something failed". Some
drivers already use error_report() and the like to emit this additional
information, so it's rather obvious that we do want a real error object
here.
v3:
- Patch 2: Keep "Could not resize image" message in qcow2_create2() by
using error_prepend() [Kevin]
- Patch 3: Dropped archipelago
- Patch 4:
- Keep errno information where available [Kevin]
- Make all drivers generate error messages [Stefan/Eric]
- Drop generic error message from bdrv_truncate() [Stefan/Eric]
Max Reitz (4):
block/vhdx: Make vhdx_create() always set errp
block: Add errp to b{lk,drv}_truncate()
block: Add errp to BD.bdrv_truncate()
block: Add .bdrv_truncate() error messages
include/block/block.h | 2 +-
include/block/block_int.h | 2 +-
include/sysemu/block-backend.h | 2 +-
block.c | 16 +++++++++++-----
block/blkdebug.c | 4 ++--
block/block-backend.c | 5 +++--
block/commit.c | 5 +++--
block/crypto.c | 5 +++--
block/file-posix.c | 19 +++++++++++++------
block/file-win32.c | 6 +++---
block/gluster.c | 7 +++++--
block/iscsi.c | 6 ++++--
block/mirror.c | 2 +-
block/nfs.c | 12 ++++++++++--
block/parallels.c | 13 ++++++++-----
block/qcow.c | 6 +++---
block/qcow2-refcount.c | 5 ++++-
block/qcow2.c | 24 +++++++++++++++---------
block/qed.c | 8 +++++---
block/raw-format.c | 6 ++++--
block/rbd.c | 3 ++-
block/sheepdog.c | 14 ++++++--------
block/vdi.c | 4 ++--
block/vhdx-log.c | 2 +-
block/vhdx.c | 25 ++++++++++++++++++-------
block/vmdk.c | 13 +++----------
block/vpc.c | 13 +++++++------
blockdev.c | 21 +--------------------
qemu-img.c | 17 ++++-------------
qemu-io-cmds.c | 5 +++--
30 files changed, 147 insertions(+), 125 deletions(-)
--
2.12.1
next reply other threads:[~2017-03-28 20:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 20:51 Max Reitz [this message]
2017-03-28 20:51 ` [Qemu-devel] [PATCH v3 for-2.10 1/4] block/vhdx: Make vhdx_create() always set errp Max Reitz
2017-03-28 20:51 ` [Qemu-devel] [PATCH v3 for-2.10 2/4] block: Add errp to b{lk, drv}_truncate() Max Reitz
2017-03-28 20:51 ` [Qemu-devel] [PATCH v3 for-2.10 3/4] block: Add errp to BD.bdrv_truncate() Max Reitz
2017-03-28 20:51 ` [Qemu-devel] [PATCH v3 for-2.10 4/4] block: Add .bdrv_truncate() error messages Max Reitz
2017-03-28 21:01 ` [Qemu-devel] [PATCH v3 for-2.10 0/4] block: Add errp to b{lk, drv}_truncate() Max Reitz
2017-03-30 12:41 ` Stefan Hajnoczi
2017-03-31 13:38 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328205129.15138-1-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.