From: Jens Axboe <axboe@kernel.dk>
To: kusumi.tomohiro@gmail.com
Cc: fio@vger.kernel.org, Tomohiro Kusumi <tkusumi@tuxera.com>
Subject: Re: [PATCH 01/13] Fix return value of make_filename() when no filename_format
Date: Tue, 28 Mar 2017 15:14:57 -0600 [thread overview]
Message-ID: <20170328211457.GA29326@kernel.dk> (raw)
In-Reply-To: <20170328200301.8622-1-tkusumi@tuxera.com>
On Tue, Mar 28 2017, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
>
> This is unlikely to happen in the first place since ->filename_format
> has a default value, and option parser can also detect an empty string,
> but it should return buf which is sprintf'd right before returning.
>
> A caller expects this function to return filename string (which is
> buf arg itself in this case), and it also doesn't handle NULL return.
Applied 1, and 3-13. Thanks!
--
Jens Axboe
prev parent reply other threads:[~2017-03-28 21:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 20:02 [PATCH 01/13] Fix return value of make_filename() when no filename_format kusumi.tomohiro
2017-03-28 20:02 ` [PATCH 02/13] Use GOLDEN_RATIO_PRIME kusumi.tomohiro
2017-03-28 20:44 ` Jens Axboe
2017-03-28 21:17 ` Tomohiro Kusumi
2017-03-28 21:19 ` Jens Axboe
2017-03-28 20:02 ` [PATCH 03/13] Test malloc result when allocation size is tunable kusumi.tomohiro
2017-03-28 20:02 ` [PATCH 04/13] Don't malloc more than necessary on extending/prereading file kusumi.tomohiro
2017-03-28 20:02 ` [PATCH 05/13] HOWTO: Mention niche detail of range format options kusumi.tomohiro
2017-03-28 20:02 ` [PATCH 06/13] Drop redundant "ignore invalidate option" message from 21c1b29e kusumi.tomohiro
2017-03-28 20:02 ` [PATCH 07/13] Ignore pre-read for FIO_NOIO td kusumi.tomohiro
2017-03-28 20:02 ` [PATCH 08/13] Don't proceed with error set when failed to pre-read files/devices kusumi.tomohiro
2017-03-28 20:02 ` [PATCH 09/13] Ignore pre-read for character devices kusumi.tomohiro
2017-03-28 20:02 ` [PATCH 10/13] Drop prototype of unused function td_io_sync() kusumi.tomohiro
2017-03-28 20:02 ` [PATCH 11/13] Separate io_u from ioengine [1/3] - add io_u.h kusumi.tomohiro
2017-03-28 20:03 ` [PATCH 12/13] Separate io_u from ioengine [2/3] - move io_u functions kusumi.tomohiro
2017-03-28 20:03 ` [PATCH 13/13] Separate io_u from ioengine [3/3] - rename ioengine.h to ioengines.h kusumi.tomohiro
2017-03-28 21:14 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328211457.GA29326@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=kusumi.tomohiro@gmail.com \
--cc=tkusumi@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.