From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v2 2/5] net/virtio: add interrupt configure for vdev Date: Wed, 29 Mar 2017 14:27:06 +0800 Message-ID: <20170329062706.GD18844@yliu-dev.sh.intel.com> References: <1488563803-87754-1-git-send-email-jianfeng.tan@intel.com> <1490689316-131625-1-git-send-email-jianfeng.tan@intel.com> <1490689316-131625-3-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, david.marchand@6wind.com, maxime.coquelin@redhat.com To: Jianfeng Tan Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id BC1562C55 for ; Wed, 29 Mar 2017 08:29:23 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1490689316-131625-3-git-send-email-jianfeng.tan@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 28, 2017 at 08:21:53AM +0000, Jianfeng Tan wrote: > For virtio PCI devices, interrupt should be configured before setting > VIRTIO_CONFIG_STATUS_DRIVER_OK so that QEMU can properly set eventfds > in the host. > > For virtio virtual devices, VIRTIO_CONFIG_STATUS_DRIVER_OK should be > set firstly, so that intr_handle is initialized in > virtio_user_start_device(). I'm wondering why can't you let virtio-user follow virtio-pci? --yliu > > To accommodate both requirements, we rearrange the sequence like this: > a. set interrupt configure for PCI devices. > b. set VIRTIO_CONFIG_STATUS_DRIVER_OK. > c. set interrupt configure for virtual devices. > > Signed-off-by: Jianfeng Tan