From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: David Rivshin <drivshin@awxrd.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: matrix_keypad: add option to drive inactive columns
Date: Wed, 29 Mar 2017 00:15:02 -0700 [thread overview]
Message-ID: <20170329071502.GC38261@dtor-ws> (raw)
In-Reply-To: <20170329020229.dm3y57dlzjwilifm@rob-hp-laptop>
On Tue, Mar 28, 2017 at 09:02:29PM -0500, Rob Herring wrote:
> On Wed, Mar 22, 2017 at 04:16:50PM -0400, David Rivshin wrote:
> > From: David Rivshin <DRivshin@allworx.com>
> >
> > The gpio-matrix-keypad driver normally sets inactive columns as inputs
> > while scanning. This does not work for all hardware, which may require
> > the inactive columns to be actively driven in order to overcome any
> > pull-ups/downs on the columns.
> >
> > Signed-off-by: David Rivshin <drivshin@allworx.com>
> > ---
> > .../devicetree/bindings/input/gpio-matrix-keypad.txt | 2 ++
> > drivers/input/keyboard/matrix_keypad.c | 13 +++++++++----
> > include/linux/input/matrix_keypad.h | 3 +++
> > 3 files changed, 14 insertions(+), 4 deletions(-)
>
> Acked-by: Rob Herring <robh@kernel.org>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2017-03-29 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 20:16 [PATCH] input: matrix_keypad: add option to drive inactive columns David Rivshin
2017-03-22 20:16 ` David Rivshin
[not found] ` <20170322201650.9072-1-drivshin-WHIoityCHfoAvxtiuMwx3w@public.gmane.org>
2017-03-29 2:02 ` Rob Herring
2017-03-29 2:02 ` Rob Herring
2017-03-29 7:15 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329071502.GC38261@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=drivshin@awxrd.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.